Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(860)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: services/service_manager/standalone/tracer.cc

Issue 2561963002: base: Remove the string logging from CHECK(). (Closed)
Patch Set: checkstring: rebase Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« remoting/host/curtain_mode_mac.cc ('K') | « services/service_manager/runner/host/linux_sandbox.cc ('k') | storage/browser/blob/blob_storage_context.cc » ('j') | ui/base/template_expressions.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: services/service_manager/standalone/tracer.cc
diff --git a/services/service_manager/standalone/tracer.cc b/services/service_manager/standalone/tracer.cc
index 20fd888e4b45e375d4865c753528cb085bcb6194..e1a62abba25380f4a1ada99dab5d8284590a97ab 100644
--- a/services/service_manager/standalone/tracer.cc
+++ b/services/service_manager/standalone/tracer.cc
@@ -40,9 +40,8 @@ void Tracer::Start(const std::string& categories,
int trace_duration_secs = 5;
if (!duration_seconds_str.empty()) {
- CHECK(base::StringToInt(duration_seconds_str, &trace_duration_secs))
- << "Could not parse --trace-startup-duration value "
- << duration_seconds_str;
+ // Could not parse --trace-startup-duration value |duration_seconds_str|.
+ CHECK(base::StringToInt(duration_seconds_str, &trace_duration_secs));
}
base::ThreadTaskRunnerHandle::Get()->PostDelayedTask(
FROM_HERE,
« remoting/host/curtain_mode_mac.cc ('K') | « services/service_manager/runner/host/linux_sandbox.cc ('k') | storage/browser/blob/blob_storage_context.cc » ('j') | ui/base/template_expressions.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698