Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(340)

Unified Diff: remoting/host/desktop_process.cc

Issue 2561963002: base: Remove the string logging from CHECK(). (Closed)
Patch Set: checkstring: rebase Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: remoting/host/desktop_process.cc
diff --git a/remoting/host/desktop_process.cc b/remoting/host/desktop_process.cc
index 3b2ae574dbaca891ee00bcda90f810669bca55dd..ed81ff9798900e12eabf06ee617384c760c8f281 100644
--- a/remoting/host/desktop_process.cc
+++ b/remoting/host/desktop_process.cc
@@ -91,7 +91,8 @@ bool DesktopProcess::OnMessageReceived(const IPC::Message& message) {
IPC_MESSAGE_UNHANDLED(handled = false)
IPC_END_MESSAGE_MAP()
- CHECK(handled) << "Received unexpected IPC type: " << message.type();
+ // Received unexpected IPC type.
+ CHECK(handled);
return handled;
}
@@ -169,7 +170,7 @@ void DesktopProcess::OnCrash(const std::string& function_name,
base::debug::Alias(message);
// The daemon requested us to crash the process.
- CHECK(false) << message;
+ LOG(FATAL) << message;
}
} // namespace remoting

Powered by Google App Engine
This is Rietveld 408576698