Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(383)

Unified Diff: remoting/client/plugin/pepper_video_renderer_3d.cc

Issue 2561963002: base: Remove the string logging from CHECK(). (Closed)
Patch Set: checkstring: rebase Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: remoting/client/plugin/pepper_video_renderer_3d.cc
diff --git a/remoting/client/plugin/pepper_video_renderer_3d.cc b/remoting/client/plugin/pepper_video_renderer_3d.cc
index aff694a2a054a778ee4f28273e9d19eb40196ac9..b2ba750e8780ebdae67365ab01c12e21c6d56bfe 100644
--- a/remoting/client/plugin/pepper_video_renderer_3d.cc
+++ b/remoting/client/plugin/pepper_video_renderer_3d.cc
@@ -210,8 +210,8 @@ void PepperVideoRenderer3D::OnSessionConfig(
graphics_, video_profile, PP_HARDWAREACCELERATION_WITHFALLBACK,
kMinimumPictureCount,
callback_factory_.NewCallback(&PepperVideoRenderer3D::OnInitialized));
- CHECK_EQ(result, PP_OK_COMPLETIONPENDING)
- << "video_decoder_.Initialize() returned " << result;
+ // video_decoder_.Initialize() returned |result|
+ CHECK_EQ(result, PP_OK_COMPLETIONPENDING);
}
protocol::VideoStub* PepperVideoRenderer3D::GetVideoStub() {
@@ -293,7 +293,8 @@ void PepperVideoRenderer3D::ProcessVideoPacket(
void PepperVideoRenderer3D::OnInitialized(int32_t result) {
// Assume that VP8 and VP9 codecs are always supported by the browser.
- CHECK_EQ(result, PP_OK) << "VideoDecoder::Initialize() failed: " << result;
+ // VideoDecoder::Initialize() failed.
+ CHECK_EQ(result, PP_OK);
initialization_finished_ = true;
// Start decoding in case a frame was received during decoder initialization.
@@ -454,7 +455,8 @@ void PepperVideoRenderer3D::PaintIfNeeded() {
}
void PepperVideoRenderer3D::OnPaintDone(int32_t result) {
- CHECK_EQ(result, PP_OK) << "Graphics3D::SwapBuffers() failed";
+ // Graphics3D::SwapBuffers() failed
+ CHECK_EQ(result, PP_OK);
paint_pending_ = false;
@@ -576,7 +578,8 @@ void PepperVideoRenderer3D::CreateShaderProgram(int type, const char* source) {
void PepperVideoRenderer3D::CheckGLError() {
GLenum error = gles2_if_->GetError(graphics_.pp_resource());
- CHECK_EQ(error, static_cast<GLenum>(GL_NO_ERROR)) << "GL error: " << error;
+ // GL error.
+ CHECK_EQ(error, static_cast<GLenum>(GL_NO_ERROR));
}
} // namespace remoting

Powered by Google App Engine
This is Rietveld 408576698