Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(649)

Unified Diff: net/spdy/spdy_stream.cc

Issue 2561963002: base: Remove the string logging from CHECK(). (Closed)
Patch Set: checkstring: rebase Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: net/spdy/spdy_stream.cc
diff --git a/net/spdy/spdy_stream.cc b/net/spdy/spdy_stream.cc
index c22928ed4bc4c9b5287d91a12d1b8b0145b1d761..8ceed640159837e5bea168a1774531f6a45c74c7 100644
--- a/net/spdy/spdy_stream.cc
+++ b/net/spdy/spdy_stream.cc
@@ -590,7 +590,7 @@ void SpdyStream::OnPaddingConsumed(size_t len) {
void SpdyStream::OnFrameWriteComplete(SpdyFrameType frame_type,
size_t frame_size) {
DCHECK_NE(type_, SPDY_PUSH_STREAM);
- CHECK(frame_type == HEADERS || frame_type == DATA) << frame_type;
+ CHECK(frame_type == HEADERS || frame_type == DATA);
int result =
(frame_type == HEADERS) ? OnHeadersSent() : OnDataSent(frame_size);
@@ -637,8 +637,7 @@ int SpdyStream::OnHeadersSent() {
}
int SpdyStream::OnDataSent(size_t frame_size) {
- CHECK(io_state_ == STATE_OPEN ||
- io_state_ == STATE_HALF_CLOSED_REMOTE) << io_state_;
+ CHECK(io_state_ == STATE_OPEN || io_state_ == STATE_HALF_CLOSED_REMOTE);
size_t frame_payload_size = frame_size - session_->GetDataFrameMinimumSize();
@@ -737,8 +736,7 @@ void SpdyStream::SendData(IOBuffer* data,
SpdySendStatus send_status) {
CHECK_NE(type_, SPDY_PUSH_STREAM);
CHECK_EQ(pending_send_status_, MORE_DATA_TO_SEND);
- CHECK(io_state_ == STATE_OPEN ||
- io_state_ == STATE_HALF_CLOSED_REMOTE) << io_state_;
+ CHECK(io_state_ == STATE_OPEN || io_state_ == STATE_HALF_CLOSED_REMOTE);
CHECK(!pending_send_data_.get());
pending_send_data_ = new DrainableIOBuffer(data, length);
pending_send_status_ = send_status;
@@ -847,8 +845,7 @@ void SpdyStream::UpdateHistograms() {
void SpdyStream::QueueNextDataFrame() {
// Until the request has been completely sent, we cannot be sure
// that our stream_id is correct.
- CHECK(io_state_ == STATE_OPEN ||
- io_state_ == STATE_HALF_CLOSED_REMOTE) << io_state_;
+ CHECK(io_state_ == STATE_OPEN || io_state_ == STATE_HALF_CLOSED_REMOTE);
CHECK_GT(stream_id_, 0u);
CHECK(pending_send_data_.get());
// Only the final fame may have a length of 0.

Powered by Google App Engine
This is Rietveld 408576698