Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(564)

Unified Diff: net/http2/hpack/decoder/hpack_entry_type_decoder.cc

Issue 2561963002: base: Remove the string logging from CHECK(). (Closed)
Patch Set: checkstring: rebase Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: net/http2/hpack/decoder/hpack_entry_type_decoder.cc
diff --git a/net/http2/hpack/decoder/hpack_entry_type_decoder.cc b/net/http2/hpack/decoder/hpack_entry_type_decoder.cc
index a05d48b1ccd77e96ecf2d0c21a981138b11c06db..ac66a23e99af8f543c7edc6b188a9bf65dc155de 100644
--- a/net/http2/hpack/decoder/hpack_entry_type_decoder.cc
+++ b/net/http2/hpack/decoder/hpack_entry_type_decoder.cc
@@ -352,8 +352,7 @@ DecodeStatus HpackEntryTypeDecoder::Start(DecodeBuffer* db) {
// All of those bits are 1, so the varint extends into another byte.
return varint_decoder_.StartExtended(0x7f, db);
}
- CHECK(false) << "Unreachable, byte=" << std::hex
- << static_cast<uint32_t>(byte);
+ CHECK(false);
return DecodeStatus::kDecodeError;
}

Powered by Google App Engine
This is Rietveld 408576698