Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(71)

Unified Diff: net/base/linked_hash_map.h

Issue 2561963002: base: Remove the string logging from CHECK(). (Closed)
Patch Set: checkstring: rebase Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: net/base/linked_hash_map.h
diff --git a/net/base/linked_hash_map.h b/net/base/linked_hash_map.h
index 8397243958c18958c77e7681857146c416f6d214..965785af8a196f0c6a19af018e6924fac2688f23 100644
--- a/net/base/linked_hash_map.h
+++ b/net/base/linked_hash_map.h
@@ -139,8 +139,8 @@ class linked_hash_map {
// map and list, a CHECK() error will occur.
iterator erase(iterator position) {
typename MapType::iterator found = map_.find(position->first);
- CHECK(found->second == position)
- << "Inconsisent iterator for map and list, or the iterator is invalid.";
+ // Inconsisent iterator for map and list, or the iterator is invalid.
+ CHECK(found->second == position);
map_.erase(found);
return list_.erase(position);
@@ -219,8 +219,8 @@ class linked_hash_map {
typename ListType::iterator last = list_.end();
--last;
- CHECK(map_.insert(std::make_pair(pair.first, last)).second)
- << "Map and list are inconsistent";
+ // Map and list are inconsistent
+ CHECK(map_.insert(std::make_pair(pair.first, last)).second);
return std::make_pair(last, true);
}

Powered by Google App Engine
This is Rietveld 408576698