Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1624)

Unified Diff: media/filters/source_buffer_range.cc

Issue 2561963002: base: Remove the string logging from CHECK(). (Closed)
Patch Set: checkstring: rebase Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: media/filters/source_buffer_range.cc
diff --git a/media/filters/source_buffer_range.cc b/media/filters/source_buffer_range.cc
index caad8cf70aa234064953f34255ff128b8ba3800b..39b900339ccf22e48fb10755e23f0180182564c8 100644
--- a/media/filters/source_buffer_range.cc
+++ b/media/filters/source_buffer_range.cc
@@ -102,8 +102,7 @@ void SourceBufferRange::Seek(DecodeTimestamp timestamp) {
KeyframeMap::iterator result = GetFirstKeyframeAtOrBefore(timestamp);
next_buffer_index_ = result->second - keyframe_map_index_base_;
- CHECK_LT(next_buffer_index_, static_cast<int>(buffers_.size()))
- << next_buffer_index_ << ", size = " << buffers_.size();
+ CHECK_LT(next_buffer_index_, static_cast<int>(buffers_.size()));
}
int SourceBufferRange::GetConfigIdAtTime(DecodeTimestamp timestamp) {
@@ -317,8 +316,7 @@ size_t SourceBufferRange::DeleteGOPFromFront(BufferQueue* deleted_buffers) {
if (next_buffer_index_ > -1) {
next_buffer_index_ -= buffers_deleted;
- CHECK_GE(next_buffer_index_, 0) << next_buffer_index_ << ", deleted "
- << buffers_deleted;
+ CHECK_GE(next_buffer_index_, 0);
}
// Invalidate range start time if we've deleted the first buffer of the range.
@@ -498,16 +496,15 @@ bool SourceBufferRange::HasNextBuffer() const {
}
int SourceBufferRange::GetNextConfigId() const {
- CHECK(HasNextBuffer()) << next_buffer_index_;
+ CHECK(HasNextBuffer());
// If the next buffer is an audio splice frame, the next effective config id
// comes from the first fade out preroll buffer.
return buffers_[next_buffer_index_]->GetConfigId();
}
DecodeTimestamp SourceBufferRange::GetNextTimestamp() const {
- CHECK(!buffers_.empty()) << next_buffer_index_;
- CHECK(HasNextBufferPosition()) << next_buffer_index_
- << ", size=" << buffers_.size();
+ CHECK(!buffers_.empty());
+ CHECK(HasNextBufferPosition());
if (next_buffer_index_ >= static_cast<int>(buffers_.size())) {
return kNoDecodeTimestamp();

Powered by Google App Engine
This is Rietveld 408576698