media/filters/decrypting_video_decoder.cc - Issue 2561963002: base: Remove the string logging from CHECK().

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: media/filters/decrypting_video_decoder.cc

Issue 2561963002: base: Remove the string logging from CHECK(). (Closed)

Patch Set: checkstring: rebase Created 4 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: media/filters/decrypting_video_decoder.cc

diff --git a/media/filters/decrypting_video_decoder.cc b/media/filters/decrypting_video_decoder.cc

index 1b541d96231644c33047c5b4e834408bb669d7d6..0f1c458b5d6af52fec447237e01d3e842d6f2eaf 100644

--- a/media/filters/decrypting_video_decoder.cc

+++ b/media/filters/decrypting_video_decoder.cc

@@ -87,7 +87,8 @@ void DecryptingVideoDecoder::Decode(const scoped_refptr<DecoderBuffer>& buffer,

state_ == kDecodeFinished ||

state_ == kError) << state_;

DCHECK(!decode_cb.is_null());

- CHECK(decode_cb_.is_null()) << "Overlapping decodes are not supported.";

+ // Overlapping decodes are not supported.

+ CHECK(decode_cb_.is_null());

decode_cb_ = BindToCurrentLoop(decode_cb);