Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(922)

Unified Diff: media/cast/sender/vp8_encoder.cc

Issue 2561963002: base: Remove the string logging from CHECK(). (Closed)
Patch Set: checkstring: rebase Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: media/cast/sender/vp8_encoder.cc
diff --git a/media/cast/sender/vp8_encoder.cc b/media/cast/sender/vp8_encoder.cc
index 39c8971e0de999faa9054b410193e8101206cbb0..47e69de86dad70e52aba772c2d842ce1a95fc7b8 100644
--- a/media/cast/sender/vp8_encoder.cc
+++ b/media/cast/sender/vp8_encoder.cc
@@ -255,12 +255,12 @@ void Vp8Encoder::Encode(const scoped_refptr<media::VideoFrame>& video_frame,
// zero to force the encoder to base its single-frame bandwidth calculations
// entirely on |predicted_frame_duration| and the target bitrate setting being
// micro-managed via calls to UpdateRates().
+ // If the check fails, invalid arguments were passed to vpx_codec_encode().
CHECK_EQ(vpx_codec_encode(&encoder_, &vpx_image, 0,
predicted_frame_duration.InMicroseconds(),
key_frame_requested_ ? VPX_EFLAG_FORCE_KF : 0,
VPX_DL_REALTIME),
- VPX_CODEC_OK)
- << "BUG: Invalid arguments passed to vpx_codec_encode().";
+ VPX_CODEC_OK);
// Pull data from the encoder, populating a new EncodedFrame.
encoded_frame->frame_id = next_frame_id_++;

Powered by Google App Engine
This is Rietveld 408576698