Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(52)

Unified Diff: media/audio/sounds/sounds_manager.cc

Issue 2561963002: base: Remove the string logging from CHECK(). (Closed)
Patch Set: checkstring: rebase Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: media/audio/sounds/sounds_manager.cc
diff --git a/media/audio/sounds/sounds_manager.cc b/media/audio/sounds/sounds_manager.cc
index c678645eae247eb460ae38f35e7c87438fb46b90..b031ba8feb0dfc98c6ac3c86314920057f4cfee0 100644
--- a/media/audio/sounds/sounds_manager.cc
+++ b/media/audio/sounds/sounds_manager.cc
@@ -98,8 +98,8 @@ SoundsManager::~SoundsManager() { DCHECK(CalledOnValidThread()); }
// static
void SoundsManager::Create() {
- CHECK(!g_instance || g_initialized_for_testing)
- << "SoundsManager::Create() is called twice";
+ // SoundsManager::Create() is called twice
+ CHECK(!g_instance || g_initialized_for_testing);
if (g_initialized_for_testing)
return;
g_instance = new SoundsManagerImpl();
@@ -107,21 +107,23 @@ void SoundsManager::Create() {
// static
void SoundsManager::Shutdown() {
- CHECK(g_instance) << "SoundsManager::Shutdown() is called "
- << "without previous call to Create()";
+ // SoundsManager::Shutdown() is called without previous call to Create()
+ CHECK(g_instance);
delete g_instance;
g_instance = NULL;
}
// static
SoundsManager* SoundsManager::Get() {
- CHECK(g_instance) << "SoundsManager::Get() is called before Create()";
+ // SoundsManager::Get() is called before Create()
+ CHECK(g_instance);
return g_instance;
}
// static
void SoundsManager::InitializeForTesting(SoundsManager* manager) {
- CHECK(!g_instance) << "SoundsManager is already initialized.";
+ // SoundsManager is already initialized.
+ CHECK(!g_instance);
CHECK(manager);
g_instance = manager;
g_initialized_for_testing = true;

Powered by Google App Engine
This is Rietveld 408576698