ios/chrome/browser/bookmarks/bookmarks_utils.cc - Issue 2561963002: base: Remove the string logging from CHECK().

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ios/chrome/browser/bookmarks/bookmarks_utils.cc

Issue 2561963002: base: Remove the string logging from CHECK(). (Closed)

Patch Set: checkstring: rebase Created 4 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: ios/chrome/browser/bookmarks/bookmarks_utils.cc

diff --git a/ios/chrome/browser/bookmarks/bookmarks_utils.cc b/ios/chrome/browser/bookmarks/bookmarks_utils.cc

index a7ece33186c047547a51343b61d6793d414e3911..b2c3a8f8e461c66d7dfa5c87d6b1d32312189b80 100644

--- a/ios/chrome/browser/bookmarks/bookmarks_utils.cc

+++ b/ios/chrome/browser/bookmarks/bookmarks_utils.cc

@@ -34,8 +34,8 @@ bool RemoveAllUserBookmarksIOS(ios::ChromeBrowserState* browser_state) {

if (!bookmark_model->client()->CanBeEditedByUser(

bookmark_model->root_node()->GetChild(i)))

continue;

- CHECK(bookmark_model->root_node()->GetChild(i)->empty())

- << "Failed to remove all user bookmarks.";

+ // Failed to remove all user bookmarks.

+ CHECK(bookmark_model->root_node()->GetChild(i)->empty());

}

// The default save folder is reset to the generic one.