Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2095)

Unified Diff: headless/app/headless_shell.cc

Issue 2561963002: base: Remove the string logging from CHECK(). (Closed)
Patch Set: checkstring: rebase Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: headless/app/headless_shell.cc
diff --git a/headless/app/headless_shell.cc b/headless/app/headless_shell.cc
index 8ae59f4fe7b0368e5e3c37568406b3b7b91c7c95..6d12120f2b68886e5bbc3a52d115f1d5f2388971 100644
--- a/headless/app/headless_shell.cc
+++ b/headless/app/headless_shell.cc
@@ -154,8 +154,8 @@ class HeadlessShell : public HeadlessWebContents::Observer,
base::CommandLine::ForCurrentProcess()->GetSwitchValueASCII(
switches::kVirtualTimeBudget);
int budget_ms;
- CHECK(base::StringToInt(budget_ms_ascii, &budget_ms))
- << "Expected an integer value for --virtual-time-budget=";
+ // Expected an integer value for --virtual-time-budget=
+ CHECK(base::StringToInt(budget_ms_ascii, &budget_ms));
devtools_client_->GetEmulation()->GetExperimental()->SetVirtualTimePolicy(
emulation::SetVirtualTimePolicyParams::Builder()
.SetPolicy(emulation::VirtualTimePolicy::
@@ -171,8 +171,8 @@ class HeadlessShell : public HeadlessWebContents::Observer,
base::CommandLine::ForCurrentProcess()->GetSwitchValueASCII(
switches::kTimeout);
int timeout_ms;
- CHECK(base::StringToInt(timeout_ms_ascii, &timeout_ms))
- << "Expected an integer value for --timeout=";
+ // Expected an integer value for --timeout=
+ CHECK(base::StringToInt(timeout_ms_ascii, &timeout_ms));
browser_->BrowserMainThread()->PostDelayedTask(
FROM_HERE,
base::Bind(&HeadlessShell::FetchTimeout, weak_factory_.GetWeakPtr()),
@@ -183,7 +183,6 @@ class HeadlessShell : public HeadlessWebContents::Observer,
}
void FetchTimeout() {
- LOG(INFO) << "Timeout.";
devtools_client_->GetPage()->GetExperimental()->StopLoading(
page::StopLoadingParams::Builder().Build());
}

Powered by Google App Engine
This is Rietveld 408576698