Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1001)

Unified Diff: extensions/renderer/worker_script_context_set.cc

Issue 2561963002: base: Remove the string logging from CHECK(). (Closed)
Patch Set: checkstring: rebase Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: extensions/renderer/worker_script_context_set.cc
diff --git a/extensions/renderer/worker_script_context_set.cc b/extensions/renderer/worker_script_context_set.cc
index c928351985d4904592b4400ea90a0d301014d4f1..54604fb972bd47ec3a1e1ea4fbbea4f2ce77ae38 100644
--- a/extensions/renderer/worker_script_context_set.cc
+++ b/extensions/renderer/worker_script_context_set.cc
@@ -44,8 +44,8 @@ void WorkerScriptContextSet::Insert(std::unique_ptr<ScriptContext> context) {
contexts_tls_.Set(contexts);
content::WorkerThread::AddObserver(this);
}
- CHECK(FindContext(contexts, context->v8_context()) == contexts->end())
- << "Worker for " << context->url() << " is already in this set";
+ // Worker for |context->url()| is already in this set
+ CHECK(FindContext(contexts, context->v8_context()) == contexts->end());
contexts->push_back(std::move(context));
}
@@ -61,8 +61,8 @@ void WorkerScriptContextSet::Remove(v8::Local<v8::Context> v8_context,
return;
}
auto context_it = FindContext(contexts, v8_context);
- CHECK(context_it != contexts->end()) << "Worker for " << url
- << " is not in this set";
+ // Worker for |url| is not in this set
+ CHECK(context_it != contexts->end());
ScriptContext* context = *context_it;
DCHECK_EQ(url, context->url());
context->Invalidate();

Powered by Google App Engine
This is Rietveld 408576698