Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(48)

Unified Diff: extensions/browser/api/alarms/alarm_manager.cc

Issue 2561963002: base: Remove the string logging from CHECK(). (Closed)
Patch Set: checkstring: rebase Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: extensions/browser/api/alarms/alarm_manager.cc
diff --git a/extensions/browser/api/alarms/alarm_manager.cc b/extensions/browser/api/alarms/alarm_manager.cc
index 626c4ce6698f2650ae73c8f28f8ceb788c02c750..442e0993cc268a920d09962c45937180fecd0af8 100644
--- a/extensions/browser/api/alarms/alarm_manager.cc
+++ b/extensions/browser/api/alarms/alarm_manager.cc
@@ -464,9 +464,8 @@ Alarm::Alarm(const std::string& name,
double* delay_in_minutes = create_info.delay_in_minutes.get();
if (delay_in_minutes == NULL)
delay_in_minutes = create_info.period_in_minutes.get();
- CHECK(delay_in_minutes != NULL)
- << "ValidateAlarmCreateInfo in alarms_api.cc should have "
- << "prevented this call.";
+ // ValidateAlarmCreateInfo in alarms_api.cc should have prevented this call.
+ CHECK(delay_in_minutes != NULL);
base::TimeDelta delay = TimeDeltaFromDelay(*delay_in_minutes);
js_alarm->scheduled_time = (now + delay).ToJsTime();
granularity = delay;

Powered by Google App Engine
This is Rietveld 408576698