Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1769)

Unified Diff: content/shell/browser/layout_test/layout_test_android.cc

Issue 2561963002: base: Remove the string logging from CHECK(). (Closed)
Patch Set: checkstring: rebase Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/shell/browser/layout_test/layout_test_android.cc
diff --git a/content/shell/browser/layout_test/layout_test_android.cc b/content/shell/browser/layout_test/layout_test_android.cc
index 45bc77f5eab784a93162c617a5a896b9cc0dad22..3a51b8f4fd931d08915b5b0d4bb6e78189bf9fe5 100644
--- a/content/shell/browser/layout_test/layout_test_android.cc
+++ b/content/shell/browser/layout_test/layout_test_android.cc
@@ -31,8 +31,8 @@ base::FilePath GetTestFilesDirectory(JNIEnv* env) {
void EnsureCreateFIFO(const base::FilePath& path) {
unlink(path.value().c_str());
- CHECK(base::android::CreateFIFO(path, 0666))
- << "Unable to create the Android's FIFO: " << path.value().c_str();
+ // Unable to create the Android's FIFO.
+ CHECK(base::android::CreateFIFO(path, 0666));
}
std::unique_ptr<base::MessagePump> CreateMessagePumpForUI() {
@@ -49,7 +49,8 @@ void EnsureInitializeForAndroidLayoutTests() {
bool success = base::MessageLoop::InitMessagePumpForUIFactory(
&CreateMessagePumpForUI);
- CHECK(success) << "Unable to initialize the message pump for Android.";
+ // Unable to initialize the message pump for Android.
+ CHECK(success);
// Android will need three FIFOs to communicate with the Blink test runner,
// one for each of [stdout, stderr, stdin].
@@ -71,7 +72,8 @@ void EnsureInitializeForAndroidLayoutTests() {
base::android::RedirectStream(stdin, stdin_fifo, "r") &&
base::android::RedirectStream(stderr, stderr_fifo, "w");
- CHECK(success) << "Unable to initialize the Android FIFOs.";
+ // Unable to initialize the Android FIFOs.
+ CHECK(success);
}
} // namespace content

Powered by Google App Engine
This is Rietveld 408576698