Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2811)

Unified Diff: content/renderer/render_frame_impl.cc

Issue 2561963002: base: Remove the string logging from CHECK(). (Closed)
Patch Set: checkstring: rebase Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/renderer/render_frame_impl.cc
diff --git a/content/renderer/render_frame_impl.cc b/content/renderer/render_frame_impl.cc
index d0cf2afee281d7320ccede5787aa0a7d6acfeafa..fbb57d86afeeb2dd231bd366eb70ab997d88b0c9 100644
--- a/content/renderer/render_frame_impl.cc
+++ b/content/renderer/render_frame_impl.cc
@@ -1145,7 +1145,8 @@ RenderFrameImpl::RenderFrameImpl(const CreateParams& params)
std::pair<RoutingIDFrameMap::iterator, bool> result =
g_routing_id_frame_map.Get().insert(std::make_pair(routing_id_, this));
- CHECK(result.second) << "Inserting a duplicate item.";
+ // Inserting a duplicate item.
+ CHECK(result.second);
RenderThread::Get()->AddRoute(routing_id_, this);
@@ -1219,7 +1220,8 @@ void RenderFrameImpl::BindToWebFrame(blink::WebLocalFrame* web_frame) {
std::pair<FrameMap::iterator, bool> result = g_frame_map.Get().insert(
std::make_pair(web_frame, this));
- CHECK(result.second) << "Inserting a duplicate item.";
+ // Inserting a duplicate item.
+ CHECK(result.second);
frame_ = web_frame;
}
@@ -4951,8 +4953,7 @@ void RenderFrameImpl::SendDidCommitProvisionalLoad(
base::debug::SetCrashKeyValue(
"origin_mismatch_same_page",
base::IntToString(params.was_within_same_page));
- CHECK(params.origin.IsSamePhysicalOriginWith(url::Origin(params.url)))
- << " url:" << params.url << " origin:" << params.origin;
+ CHECK(params.origin.IsSamePhysicalOriginWith(url::Origin(params.url)));
}
}
@@ -6185,8 +6186,8 @@ void RenderFrameImpl::LoadDataURL(
params.history_url_for_data_url, replace, load_type,
item_for_history_navigation, history_load_type, is_client_redirect);
} else {
- CHECK(false) << "Invalid URL passed: "
- << params.url.possibly_invalid_spec();
+ // Invalid URL passed.
+ CHECK(false);
}
}

Powered by Google App Engine
This is Rietveld 408576698