Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(94)

Unified Diff: content/public/test/browser_test_base.cc

Issue 2561963002: base: Remove the string logging from CHECK(). (Closed)
Patch Set: checkstring: rebase Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/public/test/browser_test_base.cc
diff --git a/content/public/test/browser_test_base.cc b/content/public/test/browser_test_base.cc
index 2333cceee12396f5938785a2917750cb748aeeef..4c1fa3930dbcba85cf72049e5671db8490ee028f 100644
--- a/content/public/test/browser_test_base.cc
+++ b/content/public/test/browser_test_base.cc
@@ -182,10 +182,10 @@ BrowserTestBase::~BrowserTestBase() {
spawned_test_server_.reset(NULL);
#endif
- CHECK(set_up_called_) << "SetUp was not called. This probably means that the "
- "developer has overridden the method and not called "
- "the superclass version. In this case, the test "
- "does not run and reports a false positive result.";
+ // SetUp was not called. This probably means that the developer has overridden
+ // the method and not called the superclass version. In this case, the test
+ // does not run and reports a false positive result.
+ CHECK(set_up_called_);
}
void BrowserTestBase::SetUp() {

Powered by Google App Engine
This is Rietveld 408576698