Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1661)

Unified Diff: content/common/sandbox_win.cc

Issue 2561963002: base: Remove the string logging from CHECK(). (Closed)
Patch Set: checkstring: rebase Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/common/sandbox_win.cc
diff --git a/content/common/sandbox_win.cc b/content/common/sandbox_win.cc
index 633012ff60d455883dfef18d8b80aa9474a3d51b..3153a05a3828943a3b6cd0ff4bc9522b83163c7b 100644
--- a/content/common/sandbox_win.cc
+++ b/content/common/sandbox_win.cc
@@ -484,14 +484,12 @@ void CheckDuplicateHandle(HANDLE handle) {
&size);
CHECK(NT_SUCCESS(error));
- CHECK(!(basic_info.GrantedAccess & WRITE_DAC)) <<
- kDuplicateHandleWarning;
+ CHECK(!(basic_info.GrantedAccess & WRITE_DAC));
if (0 == _wcsicmp(type_info->Name.Buffer, L"Process")) {
const ACCESS_MASK kDangerousMask =
~static_cast<DWORD>(PROCESS_QUERY_LIMITED_INFORMATION | SYNCHRONIZE);
- CHECK(!(basic_info.GrantedAccess & kDangerousMask)) <<
- kDuplicateHandleWarning;
+ CHECK(!(basic_info.GrantedAccess & kDangerousMask));
}
}
@@ -532,7 +530,7 @@ BOOL WINAPI DuplicateHandlePatch(HANDLE source_process_handle,
if (is_in_job) {
// We never allow inheritable child handles.
- CHECK(!inherit_handle) << kDuplicateHandleWarning;
+ CHECK(!inherit_handle);
// Duplicate the handle again, to get the final permissions.
HANDLE temp_handle;

Powered by Google App Engine
This is Rietveld 408576698