Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(473)

Unified Diff: content/browser/zygote_host/zygote_communication_linux.cc

Issue 2561963002: base: Remove the string logging from CHECK(). (Closed)
Patch Set: checkstring: rebase Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/zygote_host/zygote_communication_linux.cc
diff --git a/content/browser/zygote_host/zygote_communication_linux.cc b/content/browser/zygote_host/zygote_communication_linux.cc
index c72bdaf3f5f153de8e22cd56484f089611959d05..fd8469399a9f74aacb9e67bd3eb38c0fff3d5fdc 100644
--- a/content/browser/zygote_host/zygote_communication_linux.cc
+++ b/content/browser/zygote_host/zygote_communication_linux.cc
@@ -41,13 +41,10 @@ ZygoteCommunication::~ZygoteCommunication() {}
bool ZygoteCommunication::SendMessage(const base::Pickle& data,
const std::vector<int>* fds) {
DCHECK(control_fd_.is_valid());
- CHECK(data.size() <= kZygoteMaxMessageLength)
- << "Trying to send too-large message to zygote (sending " << data.size()
- << " bytes, max is " << kZygoteMaxMessageLength << ")";
- CHECK(!fds || fds->size() <= base::UnixDomainSocket::kMaxFileDescriptors)
- << "Trying to send message with too many file descriptors to zygote "
- << "(sending " << fds->size() << ", max is "
- << base::UnixDomainSocket::kMaxFileDescriptors << ")";
+ // Trying to send too-large message to zygote.
+ CHECK(data.size() <= kZygoteMaxMessageLength);
+ // Trying to send message with too many file descriptors to zygote.
+ CHECK(!fds || fds->size() <= base::UnixDomainSocket::kMaxFileDescriptors);
return base::UnixDomainSocket::SendMsg(control_fd_.get(), data.data(),
data.size(),

Powered by Google App Engine
This is Rietveld 408576698