Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(180)

Unified Diff: content/browser/browser_context.cc

Issue 2561963002: base: Remove the string logging from CHECK(). (Closed)
Patch Set: checkstring: rebase Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/browser_context.cc
diff --git a/content/browser/browser_context.cc b/content/browser/browser_context.cc
index 063b0efaf4013b16468213ec21ce27579b8f4108..722a2287f10b09dde7b6850cf685ece2f20ec3ec 100644
--- a/content/browser/browser_context.cc
+++ b/content/browser/browser_context.cc
@@ -482,9 +482,9 @@ void BrowserContext::Initialize(
// static
const std::string& BrowserContext::GetServiceUserIdFor(
BrowserContext* browser_context) {
- CHECK(browser_context->GetUserData(kMojoWasInitialized))
- << "Attempting to get the mojo user id for a BrowserContext that was "
- << "never Initialize()ed.";
+ // Attempting to get the mojo user id for a BrowserContext that was never
+ // Initialize()ed.
+ CHECK(browser_context->GetUserData(kMojoWasInitialized));
ServiceUserIdHolder* holder = static_cast<ServiceUserIdHolder*>(
browser_context->GetUserData(kServiceUserId));
@@ -517,9 +517,8 @@ ServiceManagerConnection* BrowserContext::GetServiceManagerConnectionFor(
}
BrowserContext::~BrowserContext() {
- CHECK(GetUserData(kMojoWasInitialized))
- << "Attempting to destroy a BrowserContext that never called "
- << "Initialize()";
+ // Attempting to destroy a BrowserContext that never called Initialize()
+ CHECK(GetUserData(kMojoWasInitialized));
DCHECK(!GetUserData(kStoragePartitionMapKeyName))
<< "StoragePartitionMap is not shut down properly";

Powered by Google App Engine
This is Rietveld 408576698