Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(9)

Unified Diff: components/sync/test/fake_server/bookmark_entity.cc

Issue 2561963002: base: Remove the string logging from CHECK(). (Closed)
Patch Set: checkstring: rebase Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/sync/test/fake_server/bookmark_entity.cc
diff --git a/components/sync/test/fake_server/bookmark_entity.cc b/components/sync/test/fake_server/bookmark_entity.cc
index a301a31b222a6d7f0031a5a5302ca93b824c9111..b25ef19799264f4756902207022c3f51cc583657 100644
--- a/components/sync/test/fake_server/bookmark_entity.cc
+++ b/components/sync/test/fake_server/bookmark_entity.cc
@@ -25,8 +25,10 @@ std::unique_ptr<FakeServerEntity> BookmarkEntity::CreateNew(
const sync_pb::SyncEntity& client_entity,
const string& parent_id,
const string& client_guid) {
- CHECK_EQ(0, client_entity.version()) << "New entities must have version = 0.";
- CHECK(IsBookmark(client_entity)) << "The given entity must be a bookmark.";
+ // New entities must have version = 0.
+ CHECK_EQ(0, client_entity.version());
+ // The given entity must be a bookmark.
+ CHECK(IsBookmark(client_entity));
const string id =
FakeServerEntity::CreateId(syncer::BOOKMARKS, base::GenerateGUID());
@@ -45,9 +47,10 @@ std::unique_ptr<FakeServerEntity> BookmarkEntity::CreateUpdatedVersion(
const sync_pb::SyncEntity& client_entity,
const FakeServerEntity& current_server_entity,
const string& parent_id) {
- CHECK_NE(0, client_entity.version()) << "Existing entities must not have a "
- << "version = 0.";
- CHECK(IsBookmark(client_entity)) << "The given entity must be a bookmark.";
+ // Existing entities must not have a version = 0.
+ CHECK_NE(0, client_entity.version());
+ // The given entity must be a bookmark.
+ CHECK(IsBookmark(client_entity));
const BookmarkEntity& current_bookmark_entity =
static_cast<const BookmarkEntity&>(current_server_entity);

Powered by Google App Engine
This is Rietveld 408576698