components/sync/engine_impl/loopback_server/loopback_server_entity.cc - Issue 2561963002: base: Remove the string logging from CHECK().

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/sync/engine_impl/loopback_server/loopback_server_entity.cc

Issue 2561963002: base: Remove the string logging from CHECK(). (Closed)

Patch Set: checkstring: rebase Created 4 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/autofill/form_structure_browsertest.cc ('K') | « components/sync/engine_impl/loopback_server/loopback_server.cc ('k') | components/sync/engine_impl/loopback_server/persistent_bookmark_entity.cc » ('j') | remoting/host/curtain_mode_mac.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/sync/engine_impl/loopback_server/loopback_server_entity.cc

diff --git a/components/sync/engine_impl/loopback_server/loopback_server_entity.cc b/components/sync/engine_impl/loopback_server/loopback_server_entity.cc

index db5a193f8d40251c3a11bd6ca10cd806dbde0df4..a080d5d968091a35d1f84cc14cb59a22e3aa9fbf 100644

--- a/components/sync/engine_impl/loopback_server/loopback_server_entity.cc

+++ b/components/sync/engine_impl/loopback_server/loopback_server_entity.cc

@@ -65,7 +65,8 @@ LoopbackServerEntity::CreateEntityFromProto(

case sync_pb::LoopbackServerEntity_Type_UNIQUE:

return PersistentUniqueClientEntity::Create(entity.entity());

case sync_pb::LoopbackServerEntity_Type_UNKNOWN:

- CHECK(false) << "Unknown type encountered";

+ // Unknown type encountered

+ CHECK(false);

return std::unique_ptr<LoopbackServerEntity>(nullptr);

}

NOTREACHED();