Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(552)

Unified Diff: components/cronet/android/test/quic_test_server.cc

Issue 2561963002: base: Remove the string logging from CHECK(). (Closed)
Patch Set: checkstring: rebase Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/cronet/android/test/quic_test_server.cc
diff --git a/components/cronet/android/test/quic_test_server.cc b/components/cronet/android/test/quic_test_server.cc
index 515b5edcddcabbaae76de25b58fbfaed7add8604..fe4b12ff50821b90f18b091321c9dc78f20994d0 100644
--- a/components/cronet/android/test/quic_test_server.cc
+++ b/components/cronet/android/test/quic_test_server.cc
@@ -41,7 +41,8 @@ void StartOnServerThread(const base::FilePath& test_files_root,
// Set up in-memory cache.
base::FilePath file_dir = test_files_root.Append("quic_data");
- CHECK(base::PathExists(file_dir)) << "Quic data does not exist";
+ // Quic data does not exist
+ CHECK(base::PathExists(file_dir));
g_quic_response_cache = new net::QuicHttpResponseCache();
g_quic_response_cache->InitializeFromDirectory(file_dir.value());
net::QuicConfig config;
@@ -62,7 +63,8 @@ void StartOnServerThread(const base::FilePath& test_files_root,
// Start listening.
int rv = g_quic_server->Listen(
net::IPEndPoint(net::IPAddress::IPv4AllZeros(), kServerPort));
- CHECK_GE(rv, 0) << "Quic server fails to start";
+ // Quic server fails to start
+ CHECK_GE(rv, 0);
JNIEnv* env = base::android::AttachCurrentThread();
Java_QuicTestServer_onServerStarted(env);
}

Powered by Google App Engine
This is Rietveld 408576698