Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(31)

Unified Diff: chromeos/network/onc/onc_test_utils.cc

Issue 2561963002: base: Remove the string logging from CHECK(). (Closed)
Patch Set: checkstring: rebase Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chromeos/network/onc/onc_test_utils.cc
diff --git a/chromeos/network/onc/onc_test_utils.cc b/chromeos/network/onc/onc_test_utils.cc
index d11f759c6727093704c22aad760cd04552c27b05..9fe09647adae0ceeb257dbf0dda0a76a9ef4ce02 100644
--- a/chromeos/network/onc/onc_test_utils.cc
+++ b/chromeos/network/onc/onc_test_utils.cc
@@ -57,13 +57,12 @@ std::unique_ptr<base::DictionaryValue> ReadTestDictionary(
std::string error_message;
std::unique_ptr<base::Value> content =
deserializer.Deserialize(NULL, &error_message);
- CHECK(content != NULL) << "Couldn't json-deserialize file '"
- << filename << "': " << error_message;
+ CHECK(content != NULL);
dict = base::DictionaryValue::From(std::move(content));
- CHECK(dict) << "File '" << filename
- << "' does not contain a dictionary as expected, but type "
- << content->GetType();
+ // File '|filename|' does not contain a dictionary as expected, but type
+ // |content->GetType()|
+ CHECK(dict);
return dict;
}

Powered by Google App Engine
This is Rietveld 408576698