Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4769)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: chrome/test/base/mojo_test_connector.cc

Issue 2561963002: base: Remove the string logging from CHECK(). (Closed)
Patch Set: checkstring: rebase Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« chrome/browser/autofill/form_structure_browsertest.cc ('K') | « chrome/test/base/extension_load_waiter_one_shot.cc ('k') | chrome/test/chromedriver/net/port_server.cc » ('j') | remoting/host/curtain_mode_mac.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/test/base/mojo_test_connector.cc
diff --git a/chrome/test/base/mojo_test_connector.cc b/chrome/test/base/mojo_test_connector.cc
index 0e41bc307f8ddf6a5ce0fb8e9214082a237d9b48..58270c31b15480e5f8dcbd5ce06b32b500c801e9 100644
--- a/chrome/test/base/mojo_test_connector.cc
+++ b/chrome/test/base/mojo_test_connector.cc
@@ -55,7 +55,8 @@ class BackgroundTestState {
test_launch_options->inherit_handles = true;
test_launch_options->handles_to_inherit = &handle_passing_info_;
#if defined(OFFICIAL_BUILD)
- CHECK(false) << "Launching mojo process with inherit_handles is insecure!";
+ // Launching mojo process with inherit_handles is insecure!
+ CHECK(false);
#endif
#elif defined(OS_POSIX)
test_launch_options->fds_to_remap = &handle_passing_info_;
« chrome/browser/autofill/form_structure_browsertest.cc ('K') | « chrome/test/base/extension_load_waiter_one_shot.cc ('k') | chrome/test/chromedriver/net/port_server.cc » ('j') | remoting/host/curtain_mode_mac.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698