Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(8447)

Unified Diff: chrome/common/extensions/api/common_extension_api_unittest.cc

Issue 2561963002: base: Remove the string logging from CHECK(). (Closed)
Patch Set: checkstring: rebase Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/common/extensions/api/common_extension_api_unittest.cc
diff --git a/chrome/common/extensions/api/common_extension_api_unittest.cc b/chrome/common/extensions/api/common_extension_api_unittest.cc
index 30a7ba7a476b8689163ed6c43661ef3597c5a9cd..af240a790584450d646962b7a1f9b152d3392cbd 100644
--- a/chrome/common/extensions/api/common_extension_api_unittest.cc
+++ b/chrome/common/extensions/api/common_extension_api_unittest.cc
@@ -525,7 +525,7 @@ scoped_refptr<Extension> CreatePackagedAppWithPermissions(
scoped_refptr<Extension> extension(Extension::Create(
base::FilePath(), Manifest::INTERNAL, values, Extension::NO_FLAGS,
&error));
- CHECK(extension.get()) << error;
+ CHECK(extension.get());
return extension;
}
@@ -754,14 +754,14 @@ static const base::DictionaryValue* GetDictChecked(
const base::DictionaryValue* dict,
const std::string& key) {
const base::DictionaryValue* out = nullptr;
- CHECK(dict->GetDictionary(key, &out)) << key;
+ CHECK(dict->GetDictionary(key, &out));
return out;
}
static std::string GetStringChecked(const base::DictionaryValue* dict,
const std::string& key) {
std::string out;
- CHECK(dict->GetString(key, &out)) << key;
+ CHECK(dict->GetString(key, &out));
return out;
}

Powered by Google App Engine
This is Rietveld 408576698