Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(651)

Unified Diff: chrome/browser/ui/toolbar/toolbar_actions_bar.cc

Issue 2561963002: base: Remove the string logging from CHECK(). (Closed)
Patch Set: checkstring: rebase Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/toolbar/toolbar_actions_bar.cc
diff --git a/chrome/browser/ui/toolbar/toolbar_actions_bar.cc b/chrome/browser/ui/toolbar/toolbar_actions_bar.cc
index 72f85cc804889a821b1695b5c2608ed721da1e22..d9b7ee84a7c88da4d09ea29aec1515aef7ddda37 100644
--- a/chrome/browser/ui/toolbar/toolbar_actions_bar.cc
+++ b/chrome/browser/ui/toolbar/toolbar_actions_bar.cc
@@ -58,8 +58,8 @@ template<typename Type1, typename Type2, typename FunctionType>
void SortContainer(std::vector<Type1>* to_sort,
const std::vector<Type2>& reference,
FunctionType equal) {
- CHECK_GE(to_sort->size(), reference.size()) <<
- "|to_sort| must contain all elements in |reference|.";
+ // |to_sort| must contain all elements in |reference|.
+ CHECK_GE(to_sort->size(), reference.size());
if (reference.empty())
return;
// Run through the each element and compare it to the reference. If something
@@ -614,9 +614,8 @@ void ToolbarActionsBar::OnToolbarActionAdded(
const ToolbarActionsModel::ToolbarItem& item,
int index) {
CHECK(model_->actions_initialized());
- CHECK(GetActionForId(item.id) == nullptr)
- << "Asked to add a toolbar action view for an action that already "
- "exists";
+ // Asked to add a toolbar action view for an action that already exists
+ CHECK(GetActionForId(item.id) == nullptr);
toolbar_actions_.insert(toolbar_actions_.begin() + index,
model_->CreateActionForItem(browser_, this, item));

Powered by Google App Engine
This is Rietveld 408576698