Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(958)

Unified Diff: chrome/browser/media/webrtc/webrtc_browsertest_audio.cc

Issue 2561963002: base: Remove the string logging from CHECK(). (Closed)
Patch Set: checkstring: rebase Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/media/webrtc/webrtc_browsertest_audio.cc
diff --git a/chrome/browser/media/webrtc/webrtc_browsertest_audio.cc b/chrome/browser/media/webrtc/webrtc_browsertest_audio.cc
index 3ed59478f354a22a1b6f7fbaa3d52c21cf3b7a2d..849e7df137aac4620553ef798e4f94372350bdbd 100644
--- a/chrome/browser/media/webrtc/webrtc_browsertest_audio.cc
+++ b/chrome/browser/media/webrtc/webrtc_browsertest_audio.cc
@@ -23,7 +23,8 @@ std::unique_ptr<char[]> ReadWavFile(const base::FilePath& wav_filename,
base::File wav_file(
wav_filename, base::File::FLAG_OPEN | base::File::FLAG_READ);
if (!wav_file.IsValid()) {
- CHECK(false) << "Failed to read " << wav_filename.value();
+ // Failed to read |wav_filename.value()|
+ CHECK(false);
return nullptr;
}
@@ -57,8 +58,8 @@ float ComputeAudioEnergyForWavFile(const base::FilePath& wav_filename,
size_t bytes_written;
wav_audio_handler->CopyTo(audio_bus.get(), 0, &bytes_written);
- CHECK_EQ(bytes_written, wav_audio_handler->data().size())
- << "Expected to write entire file into bus.";
+ // Expected to write entire file into bus.
+ CHECK_EQ(bytes_written, wav_audio_handler->data().size());
// Set the filter coefficient to the whole file's duration; this will make the
// power monitor take the entire file into account.

Powered by Google App Engine
This is Rietveld 408576698