Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(949)

Unified Diff: chrome/browser/extensions/extension_error_reporter.cc

Issue 2561963002: base: Remove the string logging from CHECK(). (Closed)
Patch Set: checkstring: rebase Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/extensions/extension_error_reporter.cc
diff --git a/chrome/browser/extensions/extension_error_reporter.cc b/chrome/browser/extensions/extension_error_reporter.cc
index 320fbd01f1d0c1880e14d89ebe50712c1a34bcb8..74cf8da3d2cbcd0b92c7f4c00a104d58940de46b 100644
--- a/chrome/browser/extensions/extension_error_reporter.cc
+++ b/chrome/browser/extensions/extension_error_reporter.cc
@@ -31,7 +31,8 @@ void ExtensionErrorReporter::Init(bool enable_noisy_errors) {
// static
ExtensionErrorReporter* ExtensionErrorReporter::GetInstance() {
- CHECK(instance_) << "Init() was never called";
+ // Init() was never called
+ CHECK(instance_);
return instance_;
}
@@ -67,8 +68,8 @@ void ExtensionErrorReporter::ReportLoadError(
void ExtensionErrorReporter::ReportError(const base::string16& message,
bool be_noisy) {
// NOTE: There won't be a |ui_task_runner_| in the unit test environment.
- CHECK(!ui_task_runner_ || ui_task_runner_->BelongsToCurrentThread())
- << "ReportError can only be called from the UI thread.";
+ // ReportError can only be called from the UI thread.
+ CHECK(!ui_task_runner_ || ui_task_runner_->BelongsToCurrentThread());
errors_.push_back(message);

Powered by Google App Engine
This is Rietveld 408576698