chrome/browser/chromeos/net/network_portal_detector_impl_browsertest.cc - Issue 2561963002: base: Remove the string logging from CHECK().

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/chromeos/net/network_portal_detector_impl_browsertest.cc

Issue 2561963002: base: Remove the string logging from CHECK(). (Closed)

Patch Set: checkstring: rebase Created 4 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/autofill/form_structure_browsertest.cc ('K') | « chrome/browser/chromeos/login/ui/simple_web_view_dialog_browsertest.cc ('k') | chrome/browser/chromeos/options/cert_library.cc » ('j') | remoting/host/curtain_mode_mac.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/chromeos/net/network_portal_detector_impl_browsertest.cc

diff --git a/chrome/browser/chromeos/net/network_portal_detector_impl_browsertest.cc b/chrome/browser/chromeos/net/network_portal_detector_impl_browsertest.cc

index 04085d5df827423d85025806b64da1af64e4ce6b..32f77a67fbdf97a830899b9e4bbec6fc90b6980f 100644

--- a/chrome/browser/chromeos/net/network_portal_detector_impl_browsertest.cc

+++ b/chrome/browser/chromeos/net/network_portal_detector_impl_browsertest.cc

@@ -56,7 +56,7 @@ const char kWifiGuid[] = "wifi";

void ErrorCallbackFunction(const std::string& error_name,

const std::string& error_message) {

- CHECK(false) << "Shill Error: " << error_name << " : " << error_message;

+ NOTREACHED() << "Shill Error: " << error_name << " : " << error_message;

}

void SetConnected(const std::string& service_path) {