Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(16)

Unified Diff: chrome/browser/chromeos/login/supervised/supervised_user_test_base.cc

Issue 2561963002: base: Remove the string logging from CHECK(). (Closed)
Patch Set: checkstring: rebase Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/chromeos/login/supervised/supervised_user_test_base.cc
diff --git a/chrome/browser/chromeos/login/supervised/supervised_user_test_base.cc b/chrome/browser/chromeos/login/supervised/supervised_user_test_base.cc
index 15dc5ac1a5a9465da3443d5316bfc57066e20229..a2f8c9f5856f74d7ecb6697da8d988d0cb7dce25 100644
--- a/chrome/browser/chromeos/login/supervised/supervised_user_test_base.cc
+++ b/chrome/browser/chromeos/login/supervised/supervised_user_test_base.cc
@@ -73,8 +73,8 @@ std::unique_ptr<::sync_pb::ManagedUserSpecifics>
SupervisedUsersSyncTestAdapter::GetFirstChange() {
std::unique_ptr<::sync_pb::ManagedUserSpecifics> result(
new ::sync_pb::ManagedUserSpecifics);
- CHECK(HasChanges())
- << "GetFirstChange() should only be callled if HasChanges() is true";
+ // GetFirstChange() should only be callled if HasChanges() is true
+ CHECK(HasChanges());
const syncer::SyncData& data = processor_->changes().front().sync_data();
EXPECT_EQ(syncer::SUPERVISED_USERS, data.GetDataType());
result->CopyFrom(data.GetSpecifics().managed_user());
@@ -122,8 +122,8 @@ std::unique_ptr<::sync_pb::ManagedUserSharedSettingSpecifics>
SupervisedUsersSharedSettingsSyncTestAdapter::GetFirstChange() {
std::unique_ptr<::sync_pb::ManagedUserSharedSettingSpecifics> result(
new ::sync_pb::ManagedUserSharedSettingSpecifics);
- CHECK(HasChanges())
- << "GetFirstChange() should only be callled if HasChanges() is true";
+ // GetFirstChange() should only be callled if HasChanges() is true
+ CHECK(HasChanges());
const syncer::SyncData& data = processor_->changes().front().sync_data();
EXPECT_EQ(syncer::SUPERVISED_USER_SHARED_SETTINGS, data.GetDataType());
result->CopyFrom(data.GetSpecifics().managed_user_shared_setting());

Powered by Google App Engine
This is Rietveld 408576698