Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(419)

Unified Diff: chrome/browser/android/vr_shell/vr_shell_renderer.cc

Issue 2561963002: base: Remove the string logging from CHECK(). (Closed)
Patch Set: checkstring: rebase Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/android/vr_shell/vr_shell_renderer.cc
diff --git a/chrome/browser/android/vr_shell/vr_shell_renderer.cc b/chrome/browser/android/vr_shell/vr_shell_renderer.cc
index 9e5159c14eb51656cafd6412dd20da4b00f91ab7..9ecfd07771aa88cd25e9e532799a2e036dc9068c 100644
--- a/chrome/browser/android/vr_shell/vr_shell_renderer.cc
+++ b/chrome/browser/android/vr_shell/vr_shell_renderer.cc
@@ -182,15 +182,15 @@ BaseRenderer::BaseRenderer(ShaderID vertex_id, ShaderID fragment_id) {
std::string error;
GLuint vertex_shader_handle = CompileShader(
GL_VERTEX_SHADER, GetShaderSource(vertex_id), error);
- CHECK(vertex_shader_handle) << error;
+ CHECK(vertex_shader_handle);
GLuint fragment_shader_handle = CompileShader(
GL_FRAGMENT_SHADER, GetShaderSource(fragment_id), error);
- CHECK(fragment_shader_handle) << error;
+ CHECK(fragment_shader_handle);
program_handle_ = CreateAndLinkProgram(vertex_shader_handle,
fragment_shader_handle, error);
- CHECK(program_handle_) << error;
+ CHECK(program_handle_);
// Once the program is linked the shader objects are no longer needed
glDeleteShader(vertex_shader_handle);

Powered by Google App Engine
This is Rietveld 408576698