Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(9899)

Unified Diff: base/trace_event/trace_config.cc

Issue 2561963002: base: Remove the string logging from CHECK(). (Closed)
Patch Set: checkstring: rebase Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: base/trace_event/trace_config.cc
diff --git a/base/trace_event/trace_config.cc b/base/trace_event/trace_config.cc
index 9a17adb969a79f12935800b2f69b8da310379d1d..04bd053c7b7235e967d56c23bb7507ef6194fedd 100644
--- a/base/trace_event/trace_config.cc
+++ b/base/trace_event/trace_config.cc
@@ -644,13 +644,13 @@ void TraceConfig::SetEventFiltersFromConfigList(
continue;
std::string predicate_name;
- CHECK(event_filter->GetString(kFilterPredicateParam, &predicate_name))
- << "Invalid predicate name in category event filter.";
+ // Invalid predicate name in category event filter.
+ CHECK(event_filter->GetString(kFilterPredicateParam, &predicate_name));
EventFilterConfig new_config(predicate_name);
const base::ListValue* included_list = nullptr;
- CHECK(event_filter->GetList(kIncludedCategoriesParam, &included_list))
- << "Missing included_categories in category event filter.";
+ // Missing included_categories in category event filter.
+ CHECK(event_filter->GetList(kIncludedCategoriesParam, &included_list));
for (size_t i = 0; i < included_list->GetSize(); ++i) {
std::string category;

Powered by Google App Engine
This is Rietveld 408576698