Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(579)

Unified Diff: base/trace_event/memory_dump_manager.cc

Issue 2561963002: base: Remove the string logging from CHECK(). (Closed)
Patch Set: checkstring: rebase Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: base/trace_event/memory_dump_manager.cc
diff --git a/base/trace_event/memory_dump_manager.cc b/base/trace_event/memory_dump_manager.cc
index 28d5d56c59d4346a9cb740d55fbbeca5aef6b603..3e603f94b296983001edde2ca4db4a3bbad0a220 100644
--- a/base/trace_event/memory_dump_manager.cc
+++ b/base/trace_event/memory_dump_manager.cc
@@ -166,13 +166,10 @@ void MemoryDumpManager::EnableHeapProfilingIfNeeded() {
AllocationContextTracker::SetCaptureMode(
AllocationContextTracker::CaptureMode::NATIVE_STACK);
#else
- CHECK(false) << "'" << profiling_mode << "' mode for "
- << switches::kEnableHeapProfiling << " flag is not supported "
- << "for this platform / build type.";
+ CHECK(false);
#endif
} else {
- CHECK(false) << "Invalid mode '" << profiling_mode << "' for "
- << switches::kEnableHeapProfiling << " flag.";
+ CHECK(false);
}
for (auto mdp : dump_providers_)

Powered by Google App Engine
This is Rietveld 408576698