Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2341)

Unified Diff: base/debug/thread_heap_usage_tracker.cc

Issue 2561963002: base: Remove the string logging from CHECK(). (Closed)
Patch Set: checkstring: rebase Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: base/debug/thread_heap_usage_tracker.cc
diff --git a/base/debug/thread_heap_usage_tracker.cc b/base/debug/thread_heap_usage_tracker.cc
index 25af20b0aa7d20ecdfa04af0bda3d6d0ab2eb884..7b4e655f41f870b424bdf8a1ac2086bf06662042 100644
--- a/base/debug/thread_heap_usage_tracker.cc
+++ b/base/debug/thread_heap_usage_tracker.cc
@@ -231,12 +231,14 @@ ThreadHeapUsage ThreadHeapUsageTracker::GetUsageSnapshot() {
void ThreadHeapUsageTracker::EnableHeapTracking() {
EnsureTLSInitialized();
- CHECK_EQ(false, g_heap_tracking_enabled) << "No double-enabling.";
+ // No double-enabling.
+ CHECK_EQ(false, g_heap_tracking_enabled);
g_heap_tracking_enabled = true;
#if BUILDFLAG(USE_EXPERIMENTAL_ALLOCATOR_SHIM)
base::allocator::InsertAllocatorDispatch(&allocator_dispatch);
#else
- CHECK(false) << "Can't enable heap tracking without the shim.";
+ // Can't enable heap tracking without the shim.
+ CHECK(false);
#endif // BUILDFLAG(USE_EXPERIMENTAL_ALLOCATOR_SHIM)
}
@@ -248,7 +250,8 @@ void ThreadHeapUsageTracker::DisableHeapTrackingForTesting() {
#if BUILDFLAG(USE_EXPERIMENTAL_ALLOCATOR_SHIM)
base::allocator::RemoveAllocatorDispatchForTesting(&allocator_dispatch);
#else
- CHECK(false) << "Can't disable heap tracking without the shim.";
+ // Can't disable heap tracking without the shim.
+ CHECK(false);
#endif // BUILDFLAG(USE_EXPERIMENTAL_ALLOCATOR_SHIM)
DCHECK_EQ(true, g_heap_tracking_enabled) << "Heap tracking not enabled.";
g_heap_tracking_enabled = false;

Powered by Google App Engine
This is Rietveld 408576698