Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3193)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: base/debug/stack_trace.cc

Issue 2561963002: base: Remove the string logging from CHECK(). (Closed)
Patch Set: checkstring: rebase Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « base/check_example.cc ('k') | base/debug/thread_heap_usage_tracker.cc » ('j') | chrome/browser/autofill/form_structure_browsertest.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: base/debug/stack_trace.cc
diff --git a/base/debug/stack_trace.cc b/base/debug/stack_trace.cc
index fb2f6b508f2e0e582299e4321c9b5ef117cd8e53..c2378f32ef2f8ab6cfa7e40f4891daf42ea9f4b7 100644
--- a/base/debug/stack_trace.cc
+++ b/base/debug/stack_trace.cc
@@ -264,8 +264,8 @@ ScopedStackFrameLinker::ScopedStackFrameLinker(void* fp, void* parent_fp)
ScopedStackFrameLinker::~ScopedStackFrameLinker() {
void* previous_parent_fp = LinkStackFrames(fp_, original_parent_fp_);
- CHECK_EQ(parent_fp_, previous_parent_fp)
- << "Stack frame's parent pointer has changed!";
+ // Stack frame's parent pointer has changed!
+ CHECK_EQ(parent_fp_, previous_parent_fp);
}
#endif // HAVE_TRACE_STACK_FRAME_POINTERS
« no previous file with comments | « base/check_example.cc ('k') | base/debug/thread_heap_usage_tracker.cc » ('j') | chrome/browser/autofill/form_structure_browsertest.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698