Move call path for resetInputMethod

third_party/WebKit/Source/core/page/FocusController.cpp

Index: third_party/WebKit/Source/core/page/FocusController.cpp
diff --git a/third_party/WebKit/Source/core/page/FocusController.cpp b/third_party/WebKit/Source/core/page/FocusController.cpp
index 89be696b17f9347030c1c3633e9cb95b47477fbe..d40e413b69168f11b53f032bc34ec274e07af2d0 100644
--- a/third_party/WebKit/Source/core/page/FocusController.cpp
+++ b/third_party/WebKit/Source/core/page/FocusController.cpp
@@ -39,6 +39,7 @@
 #include "core/editing/EditingUtilities.h"  // For firstPositionInOrBeforeNode
 #include "core/editing/Editor.h"
 #include "core/editing/FrameSelection.h"
+#include "core/editing/InputMethodController.h"
 #include "core/events/Event.h"
 #include "core/frame/FrameClient.h"
 #include "core/frame/FrameView.h"
@@ -1128,7 +1129,8 @@ bool FocusController::setFocusedElement(Element* element,
       !relinquishesEditingFocus(*oldFocusedElement))
     return false;
 
-  m_page->chromeClient().willSetInputMethodState();
+  if (oldFocusedFrame)
+    oldFocusedFrame->inputMethodController().willChangeFocusTo(element);

[yosin_UTC9, 2016/12/07 09:38:19]

yosin@'s self note:

Introducing |willChangeFocusTo()| inspires to me introducing
|didChangeFocusTo(element)| for replacement of 


Document::setFocuusElement()
    if (isRootEditableElement(*m_focusedElement))
      frame()->spellChecker().didBeginEditing(m_focusedElement.get());


void HTMLInputElement::beginEditing() {
  DCHECK(document().isActive());
  if (!document().isActive())
    return;

  if (!isTextField())
    return;

  document().frame()->spellChecker().didBeginEditing(this);
}

But, once we have idle time spell checker, we don't need to have
|SpellChecker::didBeginEditing()|.

[Changwan Ryu, 2016/12/08 01:16:30]

This sounds like a great idea. I was thinking of adding it myself for another
reason. If we have one, we can separate the logic further as

- willChangeFocusTo() finishes the current composition.
- didChangeFocusTo() updates text input state and then resets input method.

such that way input method can be restarted with the updated text input state.
Currently, it doesn't and it's causing some problem when you move focus to
another input element. (crbug.com/582576)

 
   Document* newDocument = nullptr;
   if (element)