Move call path for resetInputMethod

third_party/WebKit/Source/core/page/FocusController.cpp

 /*
  * Copyright (C) 2006, 2007 Apple Inc. All rights reserved.
  * Copyright (C) 2008 Nuanti Ltd.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions
  * are met:
  * 1. Redistributions of source code must retain the above copyright
  *    notice, this list of conditions and the following disclaimer.
  * 2. Redistributions in binary form must reproduce the above copyright
@@ skipping 21 matching lines @@
 #include "core/dom/Document.h"
 #include "core/dom/Element.h"
 #include "core/dom/ElementTraversal.h"
 #include "core/dom/Range.h"
 #include "core/dom/shadow/ElementShadow.h"
 #include "core/dom/shadow/ShadowRoot.h"
 #include "core/dom/shadow/SlotScopedTraversal.h"
 #include "core/editing/EditingUtilities.h"  // For firstPositionInOrBeforeNode
 #include "core/editing/Editor.h"
 #include "core/editing/FrameSelection.h"
+#include "core/editing/InputMethodController.h"
 #include "core/events/Event.h"
 #include "core/frame/FrameClient.h"
 #include "core/frame/FrameView.h"
 #include "core/frame/LocalDOMWindow.h"
 #include "core/frame/LocalFrame.h"
 #include "core/frame/RemoteFrame.h"
 #include "core/frame/Settings.h"
 #include "core/html/HTMLAreaElement.h"
 #include "core/html/HTMLImageElement.h"
 #include "core/html/HTMLPlugInElement.h"
@@ skipping 1069 matching lines @@
 
   Element* oldFocusedElement =
       oldDocument ? oldDocument->focusedElement() : nullptr;
   if (element && oldFocusedElement == element)
     return true;
 
   if (oldFocusedElement && isRootEditableElement(*oldFocusedElement) &&
       !relinquishesEditingFocus(*oldFocusedElement))
     return false;
 
-  m_page->chromeClient().willSetInputMethodState();
+  if (oldFocusedFrame)
+    oldFocusedFrame->inputMethodController().willChangeFocusTo(element);

[yosin_UTC9, 2016/12/07 09:38:19]

yosin@'s self note:

Introducing |willChangeFocusTo()| inspires to me introducing
|didChangeFocusTo(element)| for replacement of 


Document::setFocuusElement()
    if (isRootEditableElement(*m_focusedElement))
      frame()->spellChecker().didBeginEditing(m_focusedElement.get());


void HTMLInputElement::beginEditing() {
  DCHECK(document().isActive());
  if (!document().isActive())
    return;

  if (!isTextField())
    return;

  document().frame()->spellChecker().didBeginEditing(this);
}

But, once we have idle time spell checker, we don't need to have
|SpellChecker::didBeginEditing()|.

[Changwan Ryu, 2016/12/08 01:16:30]

This sounds like a great idea. I was thinking of adding it myself for another
reason. If we have one, we can separate the logic further as

- willChangeFocusTo() finishes the current composition.
- didChangeFocusTo() updates text input state and then resets input method.

such that way input method can be restarted with the updated text input state.
Currently, it doesn't and it's causing some problem when you move focus to
another input element. (crbug.com/582576)

 
   Document* newDocument = nullptr;
   if (element)
     newDocument = &element->document();
   else if (newFocusedFrame && newFocusedFrame->isLocalFrame())
     newDocument = toLocalFrame(newFocusedFrame)->document();
 
   if (newDocument && oldDocument == newDocument &&
       newDocument->focusedElement() == element)
     return true;
@@ skipping 269 matching lines @@
 
   return consumed;
 }
 
 DEFINE_TRACE(FocusController) {
   visitor->trace(m_page);
   visitor->trace(m_focusedFrame);
 }
 
 }  // namespace blink