Move call path for resetInputMethod

third_party/WebKit/Source/core/editing/InputMethodController.cpp

Index: third_party/WebKit/Source/core/editing/InputMethodController.cpp
diff --git a/third_party/WebKit/Source/core/editing/InputMethodController.cpp b/third_party/WebKit/Source/core/editing/InputMethodController.cpp
index bae3cea1d0ff453dbdafaf3f688cb67b036bec9d..98b9fb9a4f82c363f17df710d43b93b9b55a5cb6 100644
--- a/third_party/WebKit/Source/core/editing/InputMethodController.cpp
+++ b/third_party/WebKit/Source/core/editing/InputMethodController.cpp
@@ -1193,6 +1193,11 @@ WebTextInputType InputMethodController::textInputType() const {
   return WebTextInputTypeNone;
 }
 
+void InputMethodController::willChangeFocusTo(Element* newElement) {

[yosin_UTC9, 2016/12/07 09:38:19]

Q: Do we need to take |newElement|? It can be in another frame.

[Changwan Ryu, 2016/12/08 01:16:29]

Removed this parameter for now.

+  if (finishComposingText(DoNotKeepSelection))

[yosin_UTC9, 2016/12/07 09:38:19]

nit: Could you make early return style?

if (!finishComposingText(DoNotKeepSelection))
  return;
frame().chromeClient().resetInputMethod();

Q: Should we reset IME always? 
finishComposingText() returns false only if JS event handlers changes selection
or document.
What will be happened when we don't reset IME?
It is OK to leave IME thinks composition is still on going?

# Self note for understanding the change:
This code means if we insert composition, we reset IME.
Otherwise, do nothing.

finishComposingText() returns false if
 - no composition
 - JS change selection, by selectionstart or foucs event handler or other events
during |selectComposition()|
 - document is gone. same reason as above.

[Changwan Ryu, 2016/12/08 01:16:30]

Done
Hmm... I think the real issue here is that we're 'selecting' composition in the
process of finishComposingText and emitting JS event in the first place. We
should try to fix that.

Now I think that when there is composition and DOM changes then we should let
browser process know about the composition change, (resetting input method for
now). But it shouldn't be concerning in this CL.

+    frame().chromeClient().resetInputMethod();
+}
+
 DEFINE_TRACE(InputMethodController) {
   visitor->trace(m_frame);
   visitor->trace(m_compositionRange);