Move call path for resetInputMethod

third_party/WebKit/Source/core/editing/InputMethodController.cpp

 /*
  * Copyright (C) 2006, 2007, 2008, 2011 Apple Inc. All rights reserved.
  * Copyright (C) 2008 Nokia Corporation and/or its subsidiary(-ies)
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions
  * are met:
  * 1. Redistributions of source code must retain the above copyright
  *    notice, this list of conditions and the following disclaimer.
  * 2. Redistributions in binary form must reproduce the above copyright
@@ skipping 1175 matching lines @@
       return WebTextInputTypeDateTimeField;
   }
 
   document().updateStyleAndLayoutTree();
   if (hasEditableStyle(*element))
     return WebTextInputTypeContentEditable;
 
   return WebTextInputTypeNone;
 }
 
+void InputMethodController::willChangeFocusTo(Element* newElement) {

[yosin_UTC9, 2016/12/07 09:38:19]

Q: Do we need to take |newElement|? It can be in another frame.

[Changwan Ryu, 2016/12/08 01:16:29]

Removed this parameter for now.

+  if (finishComposingText(DoNotKeepSelection))

[yosin_UTC9, 2016/12/07 09:38:19]

nit: Could you make early return style?

if (!finishComposingText(DoNotKeepSelection))
  return;
frame().chromeClient().resetInputMethod();

Q: Should we reset IME always? 
finishComposingText() returns false only if JS event handlers changes selection
or document.
What will be happened when we don't reset IME?
It is OK to leave IME thinks composition is still on going?

# Self note for understanding the change:
This code means if we insert composition, we reset IME.
Otherwise, do nothing.

finishComposingText() returns false if
 - no composition
 - JS change selection, by selectionstart or foucs event handler or other events
during |selectComposition()|
 - document is gone. same reason as above.

[Changwan Ryu, 2016/12/08 01:16:30]

Done
Hmm... I think the real issue here is that we're 'selecting' composition in the
process of finishComposingText and emitting JS event in the first place. We
should try to fix that.

Now I think that when there is composition and DOM changes then we should let
browser process know about the composition change, (resetting input method for
now). But it shouldn't be concerning in this CL.

+    frame().chromeClient().resetInputMethod();
+}
+
 DEFINE_TRACE(InputMethodController) {
   visitor->trace(m_frame);
   visitor->trace(m_compositionRange);
   SynchronousMutationObserver::trace(visitor);
 }
 
 }  // namespace blink