cc: Devirtualize DisplayItem::ExternalMemoryUsage().

cc: Devirtualize DisplayItem::ExternalMemoryUsage().

Make it a local member on each (non-ending) display item type, and
introduce a DisplayItem type field to tell which function to call.

R=vmpstr@chromium.org
BUG=671440
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel

Committed: https://crrev.com/af5878e1056010e6d73329ddbd5a55917da87bb7
Cr-Commit-Position: refs/heads/master@{#436865}

[danakj, 2016-12-07 02:40:21]

Description was changed from

==========
cc: Devirtualize DisplayItem::ExternalMemoryUsage().

Make it a local member on each (non-ending) display item type, and
introduce a DisplayItem type field to tell which function to call.

R=vmpstr@chromium.org
BUG=671440
==========

to

==========
cc: Devirtualize DisplayItem::ExternalMemoryUsage().

Make it a local member on each (non-ending) display item type, and
introduce a DisplayItem type field to tell which function to call.

R=vmpstr@chromium.org
BUG=671440
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel
==========

[danakj, 2016-12-07 02:40:28]

The CQ bit was checked by danakj@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-07 02:40:56]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[danakj, 2016-12-07 02:41:55]

https://codereview.chromium.org/2561523002/diff/1/cc/playback/display_item_li...
File cc/playback/display_item_list.cc (left):

https://codereview.chromium.org/2561523002/diff/1/cc/playback/display_item_li...
cc/playback/display_item_list.cc:186: DISABLE_CFI_PERF
This was because we were calling virtual methods in here and it's a hot method.
Now we're not.

[vmpstr, 2016-12-07 03:11:50]

lgtm

https://codereview.chromium.org/2561523002/diff/1/cc/playback/display_item_li...
File cc/playback/display_item_list.cc (right):

https://codereview.chromium.org/2561523002/diff/1/cc/playback/display_item_li...
cc/playback/display_item_list.cc:199: size_t bytes;
nit: = 0;

[commit-bot: I haz the power, 2016-12-07 03:26:18]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-07 03:26:19]

Dry run: Try jobs failed on following builders:
  win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)

[danakj, 2016-12-07 03:47:52]

The CQ bit was checked by danakj@chromium.org

[danakj, 2016-12-07 03:47:53]

The patchset sent to the CQ was uploaded after l-g-t-m from vmpstr@chromium.org
Link to the patchset: https://codereview.chromium.org/2561523002/#ps20001
(title: "externalmem: .")

[commit-bot: I haz the power, 2016-12-07 03:48:21]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[danakj, 2016-12-07 03:48:39]

https://codereview.chromium.org/2561523002/diff/1/cc/playback/display_item_li...
File cc/playback/display_item_list.cc (right):

https://codereview.chromium.org/2561523002/diff/1/cc/playback/display_item_li...
cc/playback/display_item_list.cc:199: size_t bytes;
On 2016/12/07 03:11:50, vmpstr wrote:
> nit: = 0;

Done.

[commit-bot: I haz the power, 2016-12-07 04:54:29]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1481082472294370,
"parent_rev": "d3a7fb4efb6112458bab2a3677e83f46b36c2de2", "commit_rev":
"60e1a04fc19726e4ffa9483bbdab6fbd636bc3e0"}

[commit-bot: I haz the power, 2016-12-07 04:54:54]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-12-07 04:57:34]

Description was changed from

==========
cc: Devirtualize DisplayItem::ExternalMemoryUsage().

Make it a local member on each (non-ending) display item type, and
introduce a DisplayItem type field to tell which function to call.

R=vmpstr@chromium.org
BUG=671440
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel
==========

to

==========
cc: Devirtualize DisplayItem::ExternalMemoryUsage().

Make it a local member on each (non-ending) display item type, and
introduce a DisplayItem type field to tell which function to call.

R=vmpstr@chromium.org
BUG=671440
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel

Committed: https://crrev.com/af5878e1056010e6d73329ddbd5a55917da87bb7
Cr-Commit-Position: refs/heads/master@{#436865}
==========

[commit-bot: I haz the power, 2016-12-07 04:57:35]

Patchset 2 (id:??) landed as
https://crrev.com/af5878e1056010e6d73329ddbd5a55917da87bb7
Cr-Commit-Position: refs/heads/master@{#436865}