Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(239)

Unified Diff: cc/playback/clip_path_display_item.cc

Issue 2561523002: cc: Devirtualize DisplayItem::ExternalMemoryUsage(). (Closed)
Patch Set: externalmem: . Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « cc/playback/clip_path_display_item.h ('k') | cc/playback/compositing_display_item.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: cc/playback/clip_path_display_item.cc
diff --git a/cc/playback/clip_path_display_item.cc b/cc/playback/clip_path_display_item.cc
index e0542b220d1db3e62a5fac50917413d735e6d2a9..5b5240d4a13726df9715f670c2f75994e7660744 100644
--- a/cc/playback/clip_path_display_item.cc
+++ b/cc/playback/clip_path_display_item.cc
@@ -17,11 +17,13 @@ namespace cc {
ClipPathDisplayItem::ClipPathDisplayItem(const SkPath& clip_path,
SkClipOp clip_op,
- bool antialias) {
+ bool antialias)
+ : DisplayItem(CLIP_PATH) {
SetNew(clip_path, clip_op, antialias);
}
-ClipPathDisplayItem::ClipPathDisplayItem(const proto::DisplayItem& proto) {
+ClipPathDisplayItem::ClipPathDisplayItem(const proto::DisplayItem& proto)
+ : DisplayItem(CLIP_PATH) {
DCHECK_EQ(proto::DisplayItem::Type_ClipPath, proto.type());
const proto::ClipPathDisplayItem& details = proto.clip_path_item();
@@ -79,16 +81,10 @@ void ClipPathDisplayItem::AsValueInto(
clip_path_.countPoints(), visual_rect.ToString().c_str()));
}
-size_t ClipPathDisplayItem::ExternalMemoryUsage() const {
- // The size of SkPath's external storage is not currently accounted for (and
- // may well be shared anyway).
- return 0;
-}
-
-EndClipPathDisplayItem::EndClipPathDisplayItem() {}
+EndClipPathDisplayItem::EndClipPathDisplayItem() : DisplayItem(END_CLIP_PATH) {}
-EndClipPathDisplayItem::EndClipPathDisplayItem(
- const proto::DisplayItem& proto) {
+EndClipPathDisplayItem::EndClipPathDisplayItem(const proto::DisplayItem& proto)
+ : DisplayItem(END_CLIP_PATH) {
DCHECK_EQ(proto::DisplayItem::Type_EndClipPath, proto.type());
}
@@ -113,8 +109,4 @@ void EndClipPathDisplayItem::AsValueInto(
visual_rect.ToString().c_str()));
}
-size_t EndClipPathDisplayItem::ExternalMemoryUsage() const {
- return 0;
-}
-
} // namespace cc
« no previous file with comments | « cc/playback/clip_path_display_item.h ('k') | cc/playback/compositing_display_item.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698