Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(511)

Unified Diff: cc/playback/clip_display_item.cc

Issue 2561523002: cc: Devirtualize DisplayItem::ExternalMemoryUsage(). (Closed)
Patch Set: externalmem: . Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « cc/playback/clip_display_item.h ('k') | cc/playback/clip_path_display_item.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: cc/playback/clip_display_item.cc
diff --git a/cc/playback/clip_display_item.cc b/cc/playback/clip_display_item.cc
index c35eb22e87a9ecd72cccbd3c050f865ff4f15d0f..0d7b801174859c5f916de55d1bb8773360b2df51 100644
--- a/cc/playback/clip_display_item.cc
+++ b/cc/playback/clip_display_item.cc
@@ -22,11 +22,13 @@ class ImageSerializationProcessor;
ClipDisplayItem::ClipDisplayItem(const gfx::Rect& clip_rect,
const std::vector<SkRRect>& rounded_clip_rects,
- bool antialias) {
+ bool antialias)
+ : DisplayItem(CLIP) {
SetNew(clip_rect, rounded_clip_rects, antialias);
}
-ClipDisplayItem::ClipDisplayItem(const proto::DisplayItem& proto) {
+ClipDisplayItem::ClipDisplayItem(const proto::DisplayItem& proto)
+ : DisplayItem(CLIP) {
DCHECK_EQ(proto::DisplayItem::Type_Clip, proto.type());
const proto::ClipDisplayItem& details = proto.clip_item();
@@ -103,13 +105,10 @@ void ClipDisplayItem::AsValueInto(const gfx::Rect& visual_rect,
array->AppendString(value);
}
-size_t ClipDisplayItem::ExternalMemoryUsage() const {
- return rounded_clip_rects_.capacity() * sizeof(rounded_clip_rects_[0]);
-}
-
-EndClipDisplayItem::EndClipDisplayItem() {}
+EndClipDisplayItem::EndClipDisplayItem() : DisplayItem(END_CLIP) {}
-EndClipDisplayItem::EndClipDisplayItem(const proto::DisplayItem& proto) {
+EndClipDisplayItem::EndClipDisplayItem(const proto::DisplayItem& proto)
+ : DisplayItem(END_CLIP) {
DCHECK_EQ(proto::DisplayItem::Type_EndClip, proto.type());
}
@@ -132,8 +131,4 @@ void EndClipDisplayItem::AsValueInto(
visual_rect.ToString().c_str()));
}
-size_t EndClipDisplayItem::ExternalMemoryUsage() const {
- return 0;
-}
-
} // namespace cc
« no previous file with comments | « cc/playback/clip_display_item.h ('k') | cc/playback/clip_path_display_item.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698