Add std::string constructors for Origin/SchemeHostPort to reduce copies

Add std::string constructors for Origin/SchemeHostPort to reduce copies

WebSecurityOrigin forwards temporaries to Origin. We should just use
these, rather than consider them opaque StringPieces and copying data
out of them.

This CL also removes some dead code.

BUG=672877
Committed: https://crrev.com/f07ac3c6704c3db574549ebc2f2e9880dcbf66b7
Cr-Commit-Position: refs/heads/master@{#438054}

[Charlie Harrison, 2016-12-09 16:58:03]

The CQ bit was checked by csharrison@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-09 16:58:27]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-09 17:23:40]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-09 17:23:41]

Dry run: Try jobs failed on following builders:
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[Charlie Harrison, 2016-12-09 18:49:32]

The CQ bit was checked by csharrison@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-09 18:50:45]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Charlie Harrison, 2016-12-09 18:51:00]

Description was changed from

==========
Add std::string constructors for Origin/SchemeHostPort to reduce copies

WebSecurityOrigin forwards temporaries to Origin. We should just use
these, rather than consider than opaque StringPieces and copying data
out of them.

This CL also removes some dead code.

BUG=672877
==========

to

==========
Add std::string constructors for Origin/SchemeHostPort to reduce copies

WebSecurityOrigin forwards temporaries to Origin. We should just use
these, rather than consider them opaque StringPieces and copying data
out of them.

This CL also removes some dead code.

BUG=672877
==========

[Charlie Harrison, 2016-12-09 19:01:22]

csharrison@chromium.org changed reviewers:
+ mkwst@chromium.org

[Charlie Harrison, 2016-12-09 19:01:22]

Mike, would you review this one?

I do not really trust the move() to be done automatically as a compiler
optimization, but let me know if there's something I'm missing.

The goal here is to have the cost of WebSecurityOrigin::operator url::Origin be
be consumed by the calls to WebString::utf8() to allocate the underlying data.
Today, url::Origin::CreateFromNormalizedTupleWithSuborigin accounts for a big
percent of the cost :(

This is twofold:
 - Cost of copying the strings around (this CL addresses that)
 - Cost of SchemeHostPort IsValidInput, which calls the slow-ish
url::GetStandardSchemeType (maybe I will address in the future)

[commit-bot: I haz the power, 2016-12-09 20:49:25]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-09 20:49:26]

Dry run: This issue passed the CQ dry run.

[Mike West, 2016-12-12 08:25:46]

LGTM. I agree that this looks reasonable based on the current usage.

[Charlie Harrison, 2016-12-12 13:20:55]

csharrison@chromium.org changed reviewers:
+ creis@chromium.org

[Charlie Harrison, 2016-12-12 13:20:55]

Thanks! +creis for some dead code removal in content unit test.

[Charlie Reis, 2016-12-12 17:39:27]

content/ LGTM

[Charlie Harrison, 2016-12-12 17:39:49]

The CQ bit was checked by csharrison@chromium.org

[commit-bot: I haz the power, 2016-12-12 17:40:12]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-12 23:54:36]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-12 23:54:37]

Try jobs failed on following builders:
  linux_chromium_asan_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[Charlie Harrison, 2016-12-13 02:41:50]

The CQ bit was checked by csharrison@chromium.org

[commit-bot: I haz the power, 2016-12-13 02:42:32]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-13 04:15:08]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1481596910533370,
"parent_rev": "7620b5a59c92ff1517f9e845ded9b5d0b7920e54", "commit_rev":
"22700454313e4287b9bb31d2a4dad7dd8366105e"}

[commit-bot: I haz the power, 2016-12-13 04:16:30]

Description was changed from

==========
Add std::string constructors for Origin/SchemeHostPort to reduce copies

WebSecurityOrigin forwards temporaries to Origin. We should just use
these, rather than consider them opaque StringPieces and copying data
out of them.

This CL also removes some dead code.

BUG=672877
==========

to

==========
Add std::string constructors for Origin/SchemeHostPort to reduce copies

WebSecurityOrigin forwards temporaries to Origin. We should just use
these, rather than consider them opaque StringPieces and copying data
out of them.

This CL also removes some dead code.

BUG=672877

Review-Url: https://codereview.chromium.org/2561363002
==========

[commit-bot: I haz the power, 2016-12-13 04:16:30]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-12-13 04:21:07]

Description was changed from

==========
Add std::string constructors for Origin/SchemeHostPort to reduce copies

WebSecurityOrigin forwards temporaries to Origin. We should just use
these, rather than consider them opaque StringPieces and copying data
out of them.

This CL also removes some dead code.

BUG=672877

Review-Url: https://codereview.chromium.org/2561363002
==========

to

==========
Add std::string constructors for Origin/SchemeHostPort to reduce copies

WebSecurityOrigin forwards temporaries to Origin. We should just use
these, rather than consider them opaque StringPieces and copying data
out of them.

This CL also removes some dead code.

BUG=672877

Committed: https://crrev.com/f07ac3c6704c3db574549ebc2f2e9880dcbf66b7
Cr-Commit-Position: refs/heads/master@{#438054}
==========

[commit-bot: I haz the power, 2016-12-13 04:21:08]

Patchset 2 (id:??) landed as
https://crrev.com/f07ac3c6704c3db574549ebc2f2e9880dcbf66b7
Cr-Commit-Position: refs/heads/master@{#438054}