Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(837)

Unified Diff: url/origin_unittest.cc

Issue 2561363002: Add std::string constructors for Origin/SchemeHostPort to reduce copies (Closed)
Patch Set: fix content_unittests Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « url/origin.cc ('k') | url/scheme_host_port.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: url/origin_unittest.cc
diff --git a/url/origin_unittest.cc b/url/origin_unittest.cc
index 0f17c26ef50c40660995d818967f9db402322ef6..a5c30426f346214213f94c2b46c7da5924e48b89 100644
--- a/url/origin_unittest.cc
+++ b/url/origin_unittest.cc
@@ -90,20 +90,11 @@ TEST(OriginTest, ConstructFromTuple) {
<< test_case.port;
}
SCOPED_TRACE(scope_message);
-
- url::Origin origin_without_suborigin =
- url::Origin::CreateFromNormalizedTuple(test_case.scheme, test_case.host,
- test_case.port);
-
url::Origin origin_with_suborigin =
url::Origin::CreateFromNormalizedTupleWithSuborigin(
test_case.scheme, test_case.host, test_case.port,
test_case.suborigin);
- EXPECT_EQ(test_case.scheme, origin_without_suborigin.scheme());
- EXPECT_EQ(test_case.host, origin_without_suborigin.host());
- EXPECT_EQ(test_case.port, origin_without_suborigin.port());
-
EXPECT_EQ(test_case.scheme, origin_with_suborigin.scheme());
EXPECT_EQ(test_case.host, origin_with_suborigin.host());
EXPECT_EQ(test_case.port, origin_with_suborigin.port());
« no previous file with comments | « url/origin.cc ('k') | url/scheme_host_port.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698