Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(95)

Issue 2547533002: Add flags to enable screen orientation lock for fullscreen video on Android. (Closed)

Created:
4 years ago by mlamouri (slow - plz ping)
Modified:
4 years ago
CC:
asvitkine+watch_chromium.org, blink-reviews, chromium-reviews, creis+watch_chromium.org, darin-cc_chromium.org, feature-media-reviews_chromium.org, jam, mlamouri+watch-content_chromium.org, nasko+codewatch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add flags to enable screen orientation lock for fullscreen video on Android. Adds an entry to chrome://flags and propagate it to Blink. It is only the boilerplate. The core will be implemented in a follow-up CL. BUG=326572 R=dalecurtis@chromium.org, jochen@chromium.org, isherman@chromium.org Committed: https://crrev.com/1d266bfecede1133c0aa5c0474ec984287598a67 Cr-Commit-Position: refs/heads/master@{#436336}

Patch Set 1 #

Total comments: 2

Patch Set 2 : fix compilation #

Patch Set 3 : add histograms #

Patch Set 4 : rebased #

Unified diffs Side-by-side diffs Delta from patch set Stats (+36 lines, -0 lines) Patch
M chrome/app/generated_resources.grd View 1 2 1 chunk +8 lines, -0 lines 0 comments Download
M chrome/browser/about_flags.cc View 1 2 1 chunk +6 lines, -0 lines 0 comments Download
M content/browser/renderer_host/render_view_host_impl.cc View 1 2 1 chunk +3 lines, -0 lines 0 comments Download
M content/public/common/web_preferences.h View 1 chunk +2 lines, -0 lines 0 comments Download
M content/public/common/web_preferences.cc View 1 chunk +1 line, -0 lines 0 comments Download
M content/renderer/render_view_impl.cc View 1 2 3 1 chunk +3 lines, -0 lines 0 comments Download
M media/base/media_switches.h View 1 2 3 1 chunk +1 line, -0 lines 0 comments Download
M media/base/media_switches.cc View 1 2 3 1 chunk +4 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/platform/RuntimeEnabledFeatures.in View 1 2 3 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/web/WebRuntimeFeatures.cpp View 1 2 1 chunk +4 lines, -0 lines 0 comments Download
M third_party/WebKit/public/web/WebRuntimeFeatures.h View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M tools/metrics/histograms/histograms.xml View 1 2 3 2 chunks +2 lines, -0 lines 0 comments Download

Messages

Total messages: 31 (21 generated)
mlamouri (slow - plz ping)
dalecurtis@, PTAL at media/* jochen@, PTAL at everything else.
4 years ago (2016-12-01 13:48:39 UTC) #3
DaleCurtis
lgtm https://codereview.chromium.org/2547533002/diff/1/chrome/app/generated_resources.grd File chrome/app/generated_resources.grd (right): https://codereview.chromium.org/2547533002/diff/1/chrome/app/generated_resources.grd#newcode214 chrome/app/generated_resources.grd:214: + <message name="IDS_BACKGROUND_APP_INSTALLED_BALLOON_TITLE" desc="The title of the balloon ...
4 years ago (2016-12-01 17:45:26 UTC) #6
mlamouri (slow - plz ping)
Hopefully the rebase with the WIP CL worked, this should compile now. https://codereview.chromium.org/2547533002/diff/1/chrome/app/generated_resources.grd File chrome/app/generated_resources.grd ...
4 years ago (2016-12-01 22:12:14 UTC) #9
mlamouri (slow - plz ping)
+isherman@ for histograms.xml
4 years ago (2016-12-02 11:03:18 UTC) #14
Ilya Sherman
histograms.xml lgtm
4 years ago (2016-12-02 22:58:43 UTC) #19
jochen (gone - plz use gerrit)
lgtm please make sure to include tests when you implement the feature.
4 years ago (2016-12-05 15:27:58 UTC) #20
mlamouri (slow - plz ping)
On 2016/12/05 at 15:27:58, jochen wrote: > lgtm > > please make sure to include ...
4 years ago (2016-12-05 15:29:53 UTC) #21
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2547533002/60001
4 years ago (2016-12-05 15:32:23 UTC) #27
commit-bot: I haz the power
Committed patchset #4 (id:60001)
4 years ago (2016-12-05 17:43:08 UTC) #29
commit-bot: I haz the power
4 years ago (2016-12-05 17:45:48 UTC) #31
Message was sent while issue was closed.
Patchset 4 (id:??) landed as
https://crrev.com/1d266bfecede1133c0aa5c0474ec984287598a67
Cr-Commit-Position: refs/heads/master@{#436336}

Powered by Google App Engine
This is Rietveld 408576698