Add flags to enable screen orientation lock for fullscreen video on Android.

Add flags to enable screen orientation lock for fullscreen video on Android.

Adds an entry to chrome://flags and propagate it to Blink. It is only
the boilerplate. The core will be implemented in a follow-up CL.

BUG=326572
R=dalecurtis@chromium.org, jochen@chromium.org, isherman@chromium.org

Committed: https://crrev.com/1d266bfecede1133c0aa5c0474ec984287598a67
Cr-Commit-Position: refs/heads/master@{#436336}

[mlamouri (slow - plz ping), 2016-12-01 13:47:14]

The CQ bit was checked by mlamouri@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-01 13:47:28]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[mlamouri (slow - plz ping), 2016-12-01 13:48:39]

dalecurtis@, PTAL at media/*

jochen@, PTAL at everything else.

[commit-bot: I haz the power, 2016-12-01 14:08:47]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-01 14:08:48]

Dry run: Try jobs failed on following builders:
  linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)

[DaleCurtis, 2016-12-01 17:45:26]

lgtm

https://codereview.chromium.org/2547533002/diff/1/chrome/app/generated_resour...
File chrome/app/generated_resources.grd (right):

https://codereview.chromium.org/2547533002/diff/1/chrome/app/generated_resour...
chrome/app/generated_resources.grd:214: +          <message
name="IDS_BACKGROUND_APP_INSTALLED_BALLOON_TITLE" desc="The title of the balloon
that is displayed when a background app is installed">
Typo?

[mlamouri (slow - plz ping), 2016-12-01 22:10:55]

The CQ bit was checked by mlamouri@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-01 22:11:24]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[mlamouri (slow - plz ping), 2016-12-01 22:12:14]

Hopefully the rebase with the WIP CL worked, this should compile now.

https://codereview.chromium.org/2547533002/diff/1/chrome/app/generated_resour...
File chrome/app/generated_resources.grd (right):

https://codereview.chromium.org/2547533002/diff/1/chrome/app/generated_resour...
chrome/app/generated_resources.grd:214: +          <message
name="IDS_BACKGROUND_APP_INSTALLED_BALLOON_TITLE" desc="The title of the balloon
that is displayed when a background app is installed">
On 2016/12/01 at 17:45:26, DaleCurtis wrote:
> Typo?

Oups :)

[commit-bot: I haz the power, 2016-12-02 00:14:44]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-02 00:14:45]

Dry run: Try jobs failed on following builders:
  android_n5x_swarming_rel on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_n5x_...)
  linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)

[mlamouri (slow - plz ping), 2016-12-02 11:03:01]

Description was changed from

==========
Add flags to enable screen orientation lock for fullscreen video on Android.

Adds an entry to chrome://flags and propagate it to Blink. It is only
the boilerplate. The core will be implemented in a follow-up CL.

BUG=326572
R=dalecurtis@chromium.org, jochen@chromium.org
==========

to

==========
Add flags to enable screen orientation lock for fullscreen video on Android.

Adds an entry to chrome://flags and propagate it to Blink. It is only
the boilerplate. The core will be implemented in a follow-up CL.

BUG=326572
R=dalecurtis@chromium.org, jochen@chromium.org, isherman@chromium.org
==========

[mlamouri (slow - plz ping), 2016-12-02 11:03:18]

mlamouri@chromium.org changed reviewers:
+ isherman@chromium.org

[mlamouri (slow - plz ping), 2016-12-02 11:03:18]

+isherman@ for histograms.xml

[mlamouri (slow - plz ping), 2016-12-02 11:03:23]

The CQ bit was checked by mlamouri@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-02 11:03:42]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-02 12:51:36]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-02 12:51:37]

Dry run: This issue passed the CQ dry run.

[Ilya Sherman, 2016-12-02 22:58:43]

histograms.xml lgtm

[jochen (gone - plz use gerrit), 2016-12-05 15:27:58]

lgtm

please make sure to include tests when you implement the feature.

[mlamouri (slow - plz ping), 2016-12-05 15:29:53]

On 2016/12/05 at 15:27:58, jochen wrote:
> lgtm
> 
> please make sure to include tests when you implement the feature.

I usually do :)

[mlamouri (slow - plz ping), 2016-12-05 15:30:00]

The CQ bit was checked by mlamouri@chromium.org

[mlamouri (slow - plz ping), 2016-12-05 15:30:01]

The patchset sent to the CQ was uploaded after l-g-t-m from
dalecurtis@chromium.org
Link to the patchset: https://codereview.chromium.org/2547533002/#ps40001
(title: "add histograms")

[mlamouri (slow - plz ping), 2016-12-05 15:30:06]

The CQ bit was unchecked by mlamouri@chromium.org

[mlamouri (slow - plz ping), 2016-12-05 15:32:03]

The CQ bit was checked by mlamouri@chromium.org

[mlamouri (slow - plz ping), 2016-12-05 15:32:04]

The patchset sent to the CQ was uploaded after l-g-t-m from jochen@chromium.org,
isherman@chromium.org, dalecurtis@chromium.org
Link to the patchset: https://codereview.chromium.org/2547533002/#ps60001
(title: "rebased")

[commit-bot: I haz the power, 2016-12-05 15:32:23]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-05 17:42:40]

CQ is committing da patch.

Bot data: {"patchset_id": 60001, "attempt_start_ts": 1480951923976310,
"parent_rev": "34daed62c19285ac4998b89dedb75a063880999b", "commit_rev":
"804fa1bb29c3a74ad0b905ddcbd98c39d05aa30a"}

[commit-bot: I haz the power, 2016-12-05 17:43:08]

Committed patchset #4 (id:60001)

[commit-bot: I haz the power, 2016-12-05 17:45:47]

Description was changed from

==========
Add flags to enable screen orientation lock for fullscreen video on Android.

Adds an entry to chrome://flags and propagate it to Blink. It is only
the boilerplate. The core will be implemented in a follow-up CL.

BUG=326572
R=dalecurtis@chromium.org, jochen@chromium.org, isherman@chromium.org
==========

to

==========
Add flags to enable screen orientation lock for fullscreen video on Android.

Adds an entry to chrome://flags and propagate it to Blink. It is only
the boilerplate. The core will be implemented in a follow-up CL.

BUG=326572
R=dalecurtis@chromium.org, jochen@chromium.org, isherman@chromium.org

Committed: https://crrev.com/1d266bfecede1133c0aa5c0474ec984287598a67
Cr-Commit-Position: refs/heads/master@{#436336}
==========

[commit-bot: I haz the power, 2016-12-05 17:45:48]

Patchset 4 (id:??) landed as
https://crrev.com/1d266bfecede1133c0aa5c0474ec984287598a67
Cr-Commit-Position: refs/heads/master@{#436336}