[Turbofan] Add CallConstructWithSpread JSOperator.

[Turbofan] Add CallConstructWithSpread JSOperator.

Add the operator in preparation for actual perf work. The operator is replaced
by the same runtime call as before, during lowering.

The CallConstructWithSpreadParameters is a bit silly at the moment, but will
hold more once we add feedback.

BUG=v8:5659
Committed: https://crrev.com/291ab70f4bcfd4f95f53a497583da3906b9679fd
Cr-Commit-Position: refs/heads/master@{#41636}

[petermarshall, 2016-12-09 08:37:50]

Description was changed from

==========
[Turbofan] Add CallConstructWithSpread JSOperator.

Add the operator in preparation for actual perf work.

The CallConstructWithSpreadParameters is a bit silly at the moment, but will
hold more once we add feedback.

BUG=v8:5659
==========

to

==========
[Turbofan] Add CallConstructWithSpread JSOperator.

Add the operator in preparation for actual perf work. The operator is replaced
by the same runtime call as before, during lowering.

The CallConstructWithSpreadParameters is a bit silly at the moment, but will
hold more once we add feedback.

BUG=v8:5659
==========

[petermarshall, 2016-12-09 14:41:54]

The CQ bit was checked by petermarshall@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-09 14:42:04]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-09 15:08:52]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-09 15:08:52]

Dry run: This issue passed the CQ dry run.

[petermarshall, 2016-12-09 15:20:37]

petermarshall@chromium.org changed reviewers:
+ bmeurer@chromium.org, rmcilroy@chromium.org

[petermarshall, 2016-12-09 15:20:38]

PTAL (after the weekend :))

[Benedikt Meurer, 2016-12-11 18:04:07]

LGTM % CL separation.

https://codereview.chromium.org/2561103003/diff/40001/src/interpreter/bytecod...
File src/interpreter/bytecode-generator.cc (right):

https://codereview.chromium.org/2561103003/diff/40001/src/interpreter/bytecod...
src/interpreter/bytecode-generator.cc:2521: VisitArguments(args, args_regs, 2);
You are changing evaluation order here. Can you do that as a separate CL please?
Better keep the simple refactoring and the critical bug fix separate.

[petermarshall, 2016-12-12 08:12:25]

On 2016/12/11 at 18:04:07, bmeurer wrote:
> LGTM % CL separation.
> 
>
https://codereview.chromium.org/2561103003/diff/40001/src/interpreter/bytecod...
> File src/interpreter/bytecode-generator.cc (right):
> 
>
https://codereview.chromium.org/2561103003/diff/40001/src/interpreter/bytecod...
> src/interpreter/bytecode-generator.cc:2521: VisitArguments(args, args_regs,
2);
> You are changing evaluation order here. Can you do that as a separate CL
please? Better keep the simple refactoring and the critical bug fix separate.

Done =], thanks

[Benedikt Meurer, 2016-12-12 08:22:35]

Thanks, LGTM.

[rmcilroy, 2016-12-12 10:18:33]

lgtm

[petermarshall, 2016-12-12 10:19:00]

The CQ bit was checked by petermarshall@chromium.org

[commit-bot: I haz the power, 2016-12-12 10:19:10]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-12 10:44:15]

CQ is committing da patch.

Bot data: {"patchset_id": 60001, "attempt_start_ts": 1481537940510930,
"parent_rev": "70440f81ca557fa031315b99105186bbb3339107", "commit_rev":
"3340097784cc5e4dd83596ad07369b584916ad5f"}

[commit-bot: I haz the power, 2016-12-12 10:44:22]

Description was changed from

==========
[Turbofan] Add CallConstructWithSpread JSOperator.

Add the operator in preparation for actual perf work. The operator is replaced
by the same runtime call as before, during lowering.

The CallConstructWithSpreadParameters is a bit silly at the moment, but will
hold more once we add feedback.

BUG=v8:5659
==========

to

==========
[Turbofan] Add CallConstructWithSpread JSOperator.

Add the operator in preparation for actual perf work. The operator is replaced
by the same runtime call as before, during lowering.

The CallConstructWithSpreadParameters is a bit silly at the moment, but will
hold more once we add feedback.

BUG=v8:5659

Review-Url: https://codereview.chromium.org/2561103003
==========

[commit-bot: I haz the power, 2016-12-12 10:44:24]

Committed patchset #4 (id:60001)

[commit-bot: I haz the power, 2016-12-12 10:44:41]

Description was changed from

==========
[Turbofan] Add CallConstructWithSpread JSOperator.

Add the operator in preparation for actual perf work. The operator is replaced
by the same runtime call as before, during lowering.

The CallConstructWithSpreadParameters is a bit silly at the moment, but will
hold more once we add feedback.

BUG=v8:5659

Review-Url: https://codereview.chromium.org/2561103003
==========

to

==========
[Turbofan] Add CallConstructWithSpread JSOperator.

Add the operator in preparation for actual perf work. The operator is replaced
by the same runtime call as before, during lowering.

The CallConstructWithSpreadParameters is a bit silly at the moment, but will
hold more once we add feedback.

BUG=v8:5659

Committed: https://crrev.com/291ab70f4bcfd4f95f53a497583da3906b9679fd
Cr-Commit-Position: refs/heads/master@{#41636}
==========

[commit-bot: I haz the power, 2016-12-12 10:44:42]

Patchset 4 (id:??) landed as
https://crrev.com/291ab70f4bcfd4f95f53a497583da3906b9679fd
Cr-Commit-Position: refs/heads/master@{#41636}