Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(476)

Issue 2557963004: [Runtime] Use ElementsAccessor in NewWithSpread. (Closed)

Created:
4 years ago by petermarshall
Modified:
4 years ago
Reviewers:
Benedikt Meurer
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[Runtime] Use ElementsAccessor in NewWithSpread. Speeds up some benchmarks that make heavy use of derived constructors. BUG=chromium:672075 Committed: https://crrev.com/6051e89600733e5cd8cda110c8c68770ef485835 Cr-Commit-Position: refs/heads/master@{#41580}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -3 lines) Patch
M src/runtime/runtime-classes.cc View 2 chunks +4 lines, -3 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 13 (8 generated)
petermarshall
PTAL
4 years ago (2016-12-08 08:59:52 UTC) #4
Benedikt Meurer
Nice. LGTM.
4 years ago (2016-12-08 09:31:48 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2557963004/1
4 years ago (2016-12-08 09:32:41 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years ago (2016-12-08 09:34:20 UTC) #11
commit-bot: I haz the power
4 years ago (2016-12-08 09:34:37 UTC) #13
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/6051e89600733e5cd8cda110c8c68770ef485835
Cr-Commit-Position: refs/heads/master@{#41580}

Powered by Google App Engine
This is Rietveld 408576698