Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(47)

Issue 2560923002: [url] Remove comparisons for blob/filesystem schemes in scheme_host_port (Closed)

Created:
4 years ago by Charlie Harrison
Modified:
3 years, 11 months ago
Reviewers:
brettw
CC:
chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove comparisons for blob/filesystem schemes in scheme_host_port These are checked implicitly via the fact that blob schemes are not standard, and filesystem schemes have type SCHEME_WITHOUT_AUTHORITY. IsStandard is in critical path of loading many resources, as it is used for conversions to url::Origin. BUG=672877 Review-Url: https://codereview.chromium.org/2560923002 Cr-Commit-Position: refs/heads/master@{#442372} Committed: https://chromium.googlesource.com/chromium/src/+/39a260f9aff94ecd6d518778e2ea900f58933636

Patch Set 1 #

Patch Set 2 : Remove DCHECK, add comment to unit test (trybots prev) #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -11 lines) Patch
M url/scheme_host_port.cc View 1 1 chunk +0 lines, -6 lines 0 comments Download
M url/scheme_host_port_unittest.cc View 1 1 chunk +13 lines, -5 lines 0 comments Download

Messages

Total messages: 16 (10 generated)
Charlie Harrison
Brett, WDYT? Is it okay to punt this policy to the existing implementation? To me, ...
4 years ago (2016-12-07 21:07:14 UTC) #7
Charlie Harrison
brettw: friendly ping
3 years, 11 months ago (2017-01-03 23:43:46 UTC) #9
brettw
lgtm
3 years, 11 months ago (2017-01-09 20:23:28 UTC) #10
Charlie Harrison
Thanks!
3 years, 11 months ago (2017-01-09 20:23:53 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2560923002/20001
3 years, 11 months ago (2017-01-09 20:24:24 UTC) #13
commit-bot: I haz the power
3 years, 11 months ago (2017-01-09 22:24:55 UTC) #16
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/39a260f9aff94ecd6d518778e2ea...

Powered by Google App Engine
This is Rietveld 408576698