Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1106)

Unified Diff: url/scheme_host_port.cc

Issue 2560923002: [url] Remove comparisons for blob/filesystem schemes in scheme_host_port (Closed)
Patch Set: Remove DCHECK, add comment to unit test (trybots prev) Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | url/scheme_host_port_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: url/scheme_host_port.cc
diff --git a/url/scheme_host_port.cc b/url/scheme_host_port.cc
index 5b359a76aa4508d3783bec421110113482fe68e0..51b635dcb9d98a6acb93cece57a7b38d5df574fd 100644
--- a/url/scheme_host_port.cc
+++ b/url/scheme_host_port.cc
@@ -59,12 +59,6 @@ bool IsValidInput(const base::StringPiece& scheme,
if (!is_standard)
return false;
- // These schemes do not follow the generic URL syntax, so we treat them as
- // invalid (scheme, host, port) tuples (even though such URLs' _Origin_ might
- // have a (scheme, host, port) tuple, they themselves do not).
- if (scheme == kFileSystemScheme || scheme == kBlobScheme)
- return false;
-
switch (scheme_type) {
case SCHEME_WITH_PORT:
// A URL with |scheme| is required to have the host and port (may be
« no previous file with comments | « no previous file | url/scheme_host_port_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698